fix: add financial_governance to ComplianceConfig type (unblocks build/release)#83
Merged
Merged
Conversation
PR #79 added financial_governance usage in src/adapters/shared.ts and src/commands/validate.ts and the JSON schema, but never added the field to the ComplianceConfig TypeScript interface — breaking the build with TS2339 and blocking the npm release. Adds the financial_governance shape (enabled, firewall, spending, approval) matching all field accesses. spending.max_per_transaction_cents is required (number) so validate.ts's '<= 0' check compiles under strict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.4.0 release workflow failed at
npm run buildwith:PR #79 (financial_governance Phase 1) added the JSON schema + field usage in
shared.tsandvalidate.ts, but never addedfinancial_governanceto theComplianceConfigTypeScript interface insrc/utils/loader.ts.mainhas been failing to compile since that merge.Fix
Adds the
financial_governanceshape toComplianceConfig, matching every field access in the two consumers:enabled?,firewall?spending?→max_per_transaction_cents(requirednumbersovalidate.ts's<= 0compiles understrict),max_monthly_cents?,currency?,allowed_categories?,blocked_categories?approval?→require_above_cents?,timeout_minutes?,auto_deny_on_timeout?Test plan
npm run buildcompiles (the CI workflow will confirm)