Add notification-kit SDK with client and server exports#1
Open
Add notification-kit SDK with client and server exports#1
Conversation
Implements the core @open-game-system/notification-kit package with: - Client SDK (.) for OGS WebView detection and device ID retrieval - React bindings (./react) with NotificationProvider and useNotifications hook - Server SDK (./server) with createNotificationClient for sending push notifications - Dual ESM/CJS build via tsup with full TypeScript declarations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove unused `i` parameter from results.map callback to fix TypeScript noUnusedParameters error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit: - Seeds AGENTS.md and CLAUDE.md symlink - Adds docs/architecture.md, lessons.md, and quality.md - Sets up GitHub Actions CI workflow with dev/prod publish jobs - Configures vitest and adds 100% logic coverage tests for core, server, and React
|
📦 Dev version published: Install via GitHub Packages (ensure .npmrc is configured): npm install @open-game-system/notification-kit@0.20260313.0-pr1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@open-game-system/notification-kitpackage with three subpath exports:.(client core),./react(React bindings), and./server(server-side notification client)createNotificationClientfor sending push notifications through the OGS APITest plan
npm run buildproduces correct output indist/npm run typecheckpasses with no errors🤖 Generated with Claude Code