Execute step (not) applicable action on all steps#6114
Merged
sergei-maertens merged 2 commits intomainfrom Mar 27, 2026
Merged
Conversation
…ted on all steps The fix for #5996, where we execute this rule from the first determined step, only solves part of the problem. For example: if a user submits a certain step, causing a future step to be not applicable, but then navigates back to a step before the step with the not applicable action -> the not applicable step will be marked as applicable again in the progress indicator, because the rule is never executed. To fix this, we execute rules with a step (not) applicable action on all steps. With the logic evaluation in the frontend, performance should not suffer much, because these rules are executed almost instantly. An alternative solution where we create submission steps upon submission creation, and persist the "is_applicable" flag to the database, is still tricky (but not impossible) for the reason described in #6035. If it turns out the solution implemented here was the wrong one, we can decide to switch to this alternative solution anyway. I do realize something while writing this, actually. The logic rules will be ordered based on input/output variable dependencies. If there is none, the step order will be used. Because we execute these rules on all steps now, they might show up near the beginning of the logic rule list, even when the action applies to a later step. I guess we have to see how will look exactly, and if form designers experience confusion with this.
Now that rules with a step (not) applicable action will be executed on all steps, it makes sense to include a special message instead of listing all the step names.
viktorvanwijk
force-pushed
the
chore/6099-execute-step-(not)-applicable-action-on-all-steps
branch
from
9419269 to
7d36e1d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6114 +/- ##
==========================================
- Coverage 97.09% 97.07% -0.02%
==========================================
Files 883 883
Lines 33189 33210 +21
Branches 2972 2975 +3
==========================================
+ Hits 32225 32239 +14
- Misses 648 655 +7
Partials 316 316 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergei-maertens
approved these changes
Mar 27, 2026
sergei-maertens
deleted the
chore/6099-execute-step-(not)-applicable-action-on-all-steps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6099
[skip: e2e]
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Dockerfile/scripts
./binfolderCommit hygiene
Documentation