Skip to content

[#5957] add payment related fields to v3 form endpoint#6033

Merged
sergei-maertens merged 1 commit intomainfrom
feature/5957-payment-configuration
Mar 27, 2026
Merged

[#5957] add payment related fields to v3 form endpoint#6033
sergei-maertens merged 1 commit intomainfrom
feature/5957-payment-configuration

Conversation

@SonnyBA
Copy link
Copy Markdown
Contributor

@SonnyBA SonnyBA commented Mar 3, 2026

Closes #5957

[skip: e2e]

Changes

Adds payment related fields to the v3 form endpoint.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Checked new model fields are usable in the admin
    • Problem detection in the admin email digest is handled
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how
  • Documentation

    • Added documentation which describes the changes

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.07%. Comparing base (4142dff) to head (96ed4a8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/openforms/forms/api/v3/serializers/payment.py 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6033      +/-   ##
==========================================
- Coverage   97.07%   97.07%   -0.01%     
==========================================
  Files         883      884       +1     
  Lines       33225    33265      +40     
  Branches     2978     2979       +1     
==========================================
+ Hits        32254    32292      +38     
- Misses        655      656       +1     
- Partials      316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SonnyBA SonnyBA force-pushed the feature/5957-payment-configuration branch 2 times, most recently from e1b7355 to 7c39233 Compare March 4, 2026 09:41
@SonnyBA SonnyBA marked this pull request as ready for review March 4, 2026 09:52
@SonnyBA SonnyBA force-pushed the feature/5957-payment-configuration branch 3 times, most recently from fb4825a to 6ade3a5 Compare March 12, 2026 15:56
@SonnyBA SonnyBA force-pushed the feature/5957-payment-configuration branch 3 times, most recently from 768b24e to cf7c2d0 Compare March 24, 2026 11:05
Comment thread src/openforms/api/service.py Outdated
Comment thread src/openforms/forms/api/v3/serializers/form.py Outdated
Comment thread src/openforms/forms/api/v3/serializers/form.py Outdated
Comment thread src/openforms/forms/api/v3/serializers/form.py Outdated
@SonnyBA SonnyBA force-pushed the feature/5957-payment-configuration branch 2 times, most recently from 6dc38fd to e87b949 Compare March 26, 2026 10:37
@sergei-maertens sergei-maertens force-pushed the feature/5957-payment-configuration branch from e87b949 to d08410c Compare March 27, 2026 11:35
@sergei-maertens sergei-maertens force-pushed the feature/5957-payment-configuration branch from d08410c to 97eeb89 Compare March 27, 2026 11:41
@sergei-maertens sergei-maertens force-pushed the feature/5957-payment-configuration branch from 97eeb89 to 96ed4a8 Compare March 27, 2026 11:55
@sergei-maertens sergei-maertens merged commit fd782a9 into main Mar 27, 2026
29 of 31 checks passed
@sergei-maertens sergei-maertens deleted the feature/5957-payment-configuration branch March 27, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for payment configuration

2 participants