Draft
Conversation
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5670 +/- ##
==========================================
- Coverage 97.00% 96.98% -0.03%
==========================================
Files 835 835
Lines 30001 30078 +77
Branches 3895 3908 +13
==========================================
+ Hits 29103 29171 +68
- Misses 605 610 +5
- Partials 293 297 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WFS tile layers are similar to WMS tile layers, in the way that they both allow additional information to be presented in a map component. WFS takes it one step further, to allow the user to interact with the added visuals. The WFS version of BAG has been added as default WFS tile layer, to quickly let users become familiar with the new functionality. The WFS tile layers can be imported and exported from the WFS tile layers configuration page in the admin. This allows quick and easy sharing of WFS tile layers between OF instances.
Just like the background layers and WMS layers, this is exposed through a simple JSON object dumped in the template context - there is no need to add additional API endpoints.
To showcase the map component overlays, we need to know which url corresponds to the selected tile layer. By fetching the url before the component is shown in the form, ensure that we have the current and correct url.
Map component configuration can become invalid in multiple ways: - tile layer source that updates its available layers/feature types - tile layers that are removed in OF - tile layer sources that are no-longer available The email digest for WMS has been transformed into a generic map overlay check, which covers WMS and WFS. Internally WMS and WFS are still handled separately, because of their different XML structures and rules.
By using the namespaces that are actually set on the WMS and WFS tile layers, we can support more sources than just openGIS. In addition, by checking the availability of the namespaces, we can target the xml content more accurately.
robinmolen
force-pushed
the
feature/5576-wfs-map-ovelays
branch
from
27a25dc to
2597156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #5576
This PR relies on a new version of the Formio-builder, to support WFS tile layer configuration on map components. This should not be merged, until the Formio-builder has been updated and the dependency in this PR has been upgraded!
Changes
Added configuration for WFS tile layers, exposed the WFS tile layers to the formio-builder, and extended the email digest checking.
The implementation is mostly the same as the implementation for the WMS tile layers: using the same structure and naming for the model fields. The WFS tile layers can also be imported and exported through the admin configuration page.
The email digest for WMS has been altered to a more generic map overlay check. Both WMS and WFS tile layers are now checked and reported for problems.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Dockerfile/scripts
./binfolderCommit hygiene