Grab and save the branch number from eHerkenning service restriction

[sergei-maertens]

Closes #3967

[skip: e2e]

This is really hard to test/try out because we don't have a real eherkenning setup with a branch service restriction as far as I can tell...

However, piecing together the documentation on:
https://afsprakenstelsel.etoegang.nl/Startpagina/v2/interface-specifications-dv-hm (which describes the interface between service provider and makelaar), we should get back the ServiceRestriction SAML attribute if information is available in the MR (machtigingsregister). The examples show that it would not be an encrypted attribute (it sits in the AttributeStatement element):

<saml:Attribute Name=urn:etoegang:1.9:ServiceRestriction:Vestigingsnr>
    <saml:AttributeValue xsi:type=xs:string>123456789012</saml:AttributeValue>
</saml:Attribute>

The documentation says it would be one or more restriction, so we're assuming that it returns a list of strings of values after processing, similar to the urn:etoegang:core:ServiceID and urn:etoegang:core:ServiceUUID attributes.

I checked our code in django-digid-eherkenning, and we already by default include the service restriction request in the catalogus request, so no extra work should be needed there, see: https://github.com/maykinmedia/django-digid-eherkenning/blob/0189aceea660d2f4774d238397365f17adeb354a/digid_eherkenning/models/eherkenning.py#L234

Changes

• Grab the service restriction from the extracted attributes
• Add tests (preferably VCR with a real setup and no mocking)

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[sergei-maertens]

this is pretty nasty and a setup similar to the OIDC variants where everything is scoped under a single session key would be better

[sergei-maertens]

@joeribekker we really need to test this with a representative test account that has a branch restriction

[sergei-maertens]

Reached out to a SAAS customer to see if we can get "inspiration" for Signicat configuration for this.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.69%. Comparing base (4e6d5c1) to head (6e37953).
⚠️ Report is 1933 commits behind head on main.

Files with missing lines	Patch %	Lines
...forms/authentication/contrib/eherkenning/plugin.py	58.33%	4 Missing and 1 partial ⚠️
...nforms/authentication/contrib/eherkenning/views.py	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4525      +/-   ##
==========================================
- Coverage   96.72%   96.69%   -0.03%     
==========================================
  Files         778      778              
  Lines       26875    26891      +16     
  Branches     3511     3514       +3     
==========================================
+ Hits        25995    26003       +8     
- Misses        612      618       +6     
- Partials      268      270       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[joeribekker]

Signicat seems to have "almost" the same BUT uses an alias for the name:

            <saml2:Attribute Name="eherkenningVestigingsNr">
                <saml2:AttributeValue>123400567890</saml2:AttributeValue>
            </saml2:Attribute>

Source: https://developer.signicat.com/identity-methods/eherkenning/attributes-reference/eherkenning-attributes-saml/