Open
Conversation
6 tasks
robinmolen
force-pushed
the
feature/12-information-page
branch
from
33a4375 to
9778476
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 79.45% 86.16% +6.71%
==========================================
Files 39 42 +3
Lines 292 318 +26
Branches 51 54 +3
==========================================
+ Hits 232 274 +42
+ Misses 54 37 -17
- Partials 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SonnyBA
reviewed
Mar 31, 2026
|
Also noticed the checkbox for saving the form in between steps was missing: Should that also be added in this PR? |
Contributor
Author
|
No idea how i missed the checkbox field... Adding it. I've also added the "Form URL" field, as the required release of the Maykin admin-ui was available |
We require access to the v2 and v3 api endpoints. To make this easily doable, we now use a v2 BASE_URL and a v3 BASE_URL.
The api-mocks `BASE_URL` should only be used for tests instances. Every other place in the code should use either the API urls provided through the AdminSettings context, or directly from the AdminUI main component
Added readonly as a textfield property, which adds the accessible 'readonly' attribute to the input element.
Adding `margin-block-end` to the FormField wrapper, adding spacing between form fields. Also added additional styling to select and input fields inside the FormField, ensuring they grow to 100% the size of the FormField wrapper.
…ation settings page For the 'Form URL' field a new UrlField was added, contained within the Information page domain. As this component is now only used by the Information page, it makes sense to tightly couple it with the Information component. The UrlField provides a read-only text input, with a copy button. Currently the input value is constructed from the form slug field + the djangoUrls 'publicRoot'
robinmolen
force-pushed
the
feature/12-information-page
branch
from
9778476 to
d4b3985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #12
PR adds:
The public url field still needs to be added, this requires maykinmedia/admin-ui#327. Lets do that in a separate PR