Skip to content

chore(ci): add cargo-semver-checks to flagd/ofrep release PRs #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erenatas wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(ci): add cargo-semver-checks to flagd/ofrep release PRs #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bfddb5
feat(ci): add cargo-semver-checks to lint workflow
erenatas Jan 3, 2026
362b0fb
use it only for flagd and ofrep
erenatas Jan 3, 2026
cddac1e
use it only for flagd and ofrep in release PRs
erenatas Jan 3, 2026
7b31ccd
undo condition
erenatas Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/workflows/flagd-ofrep-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ on:
- 'crates/flagd/**'
- 'crates/ofrep/**'
- '.github/workflows/flagd-ofrep-check.yml'
pull_request:
Copy link
Copy Markdown
Member

@erka erka Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double definition of pull_request?

I don’t see this action running in this PR.

Copy link
Copy Markdown
Contributor Author

@erenatas erenatas Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look at it this week, btw @erka would you consider being a Rust contributor in open-feature org? Your comments are valuable and very helpful and I would be more than happy to have your support 🙇

Copy link
Copy Markdown
Member

@erka erka Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to the idea in general. Time is the only limitation.

types:
- opened
- synchronize

jobs:
check:
Expand Down Expand Up @@ -44,10 +48,27 @@ jobs:
run: |
cargo readme --no-title --no-license > README.md.generated
diff README.md README.md.generated

- name: Install and run cargo-audit
run: |
cargo install cargo-audit --locked
# Run from root directory where Cargo.lock is located
cargo audit

release-semver-checks:
if: github.event_name == 'pull_request' && startsWith(github.event.pull_request.title, 'chore(main): release')
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5

- name: Install Rust
run: rustup update --no-self-update stable && rustup default stable

- name: Install cargo-semver-checks
run: cargo install cargo-semver-checks

- name: Check semver for flagd and ofrep
run: |
cargo semver-checks check-release --package open-feature-flagd
cargo semver-checks check-release --package open-feature-ofrep
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ jobs:
uses: Swatinem/rust-cache@v2

- name: Check code quality
run: cargo clippy -- -D warnings
run: cargo clippy -- -D warnings