chore: relax uv, fix unleash e2e test stability#375
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests for the Unleash provider by configuring database pool limits to prevent concurrent migration errors and removing a redundant postgres.start() call within a context manager. Additionally, the required version for uv in pyproject.toml has been updated to >=0.10.0. I have no feedback to provide.
e545f15 to
a38dfc2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 90.16% 98.72% +8.56%
==========================================
Files 1 3 +2
Lines 122 157 +35
==========================================
+ Hits 110 155 +45
+ Misses 12 2 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1c8a672 to
c991b25
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
c991b25 to
cd29267
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request enhances the Unleash integration tests by implementing a retry mechanism for container startup to mitigate database migration race conditions. It refactors health check and logging logic into helper functions and updates the uv version requirement in pyproject.toml. A review comment identifies a redundant container.start() call within a context manager, suggesting its removal for consistency and brevity.
providers/openfeature-provider-unleash/tests/test_integration.py
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Still trying to fix some race conditions here.