Skip to content

chore: relax uv, fix unleash e2e test stability#375

Merged
toddbaert merged 2 commits intomainfrom
chore/unleash-e2e-stability
Mar 31, 2026
Merged

chore: relax uv, fix unleash e2e test stability#375
toddbaert merged 2 commits intomainfrom
chore/unleash-e2e-stability

Conversation

@toddbaert
Copy link
Copy Markdown
Member

Still trying to fix some race conditions here.

@toddbaert toddbaert requested review from a team as code owners March 31, 2026 16:05
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration tests for the Unleash provider by configuring database pool limits to prevent concurrent migration errors and removing a redundant postgres.start() call within a context manager. Additionally, the required version for uv in pyproject.toml has been updated to >=0.10.0. I have no feedback to provide.

@toddbaert toddbaert force-pushed the chore/unleash-e2e-stability branch from e545f15 to a38dfc2 Compare March 31, 2026 16:15
@toddbaert toddbaert closed this Mar 31, 2026
@toddbaert toddbaert reopened this Mar 31, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.72%. Comparing base (7e18bc1) to head (29bad68).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   90.16%   98.72%   +8.56%     
==========================================
  Files           1        3       +2     
  Lines         122      157      +35     
==========================================
+ Hits          110      155      +45     
+ Misses         12        2      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toddbaert toddbaert force-pushed the chore/unleash-e2e-stability branch 2 times, most recently from 1c8a672 to c991b25 Compare March 31, 2026 18:28
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert force-pushed the chore/unleash-e2e-stability branch from c991b25 to cd29267 Compare March 31, 2026 18:30
@toddbaert
Copy link
Copy Markdown
Member Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the Unleash integration tests by implementing a retry mechanism for container startup to mitigate database migration race conditions. It refactors health check and logging logic into helper functions and updates the uv version requirement in pyproject.toml. A review comment identifies a redundant container.start() call within a context manager, suggesting its removal for consistency and brevity.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert merged commit 81de6ba into main Mar 31, 2026
14 checks passed
@toddbaert toddbaert deleted the chore/unleash-e2e-stability branch March 31, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant