Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
bot
added
the
size:L
toddbaert
force-pushed
the
docs/fractional-updates
branch
from
efd0f85 to
eb81997
Compare
toddbaert
requested review from
aepfli,
askpt,
beeme1mr,
chrfwow and
leakonvalinka
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the fractional operation by introducing support for high-precision weights and dynamic weight calculations using JSONLogic, accompanied by updated documentation and a new gradual rollout scenario in the playground app. It also upgrades @openfeature/flagd-core to version 3 and deprecates the selector field in the gRPC specifications. Review feedback points out that manual modifications to auto-generated proto documentation will be overwritten and currently break Markdown table formatting. Furthermore, it is recommended to maintain a minItems value of 2 for fractional operations in the JSON schema to align with the evaluator's implementation requirements.
toddbaert
force-pushed
the
docs/fractional-updates
branch
from
eb81997 to
f15a706
Compare
toddbaert
changed the title
toddbaert
changed the title
toddbaert
force-pushed
the
docs/fractional-updates
branch
from
f15a706 to
024ca05
Compare
| @@ -3,9 +3,9 @@ import { contextToPrettyJson, featureDefinitionToPrettyJson } from "../utils"; | |||
|
|
|||
| export const progressRollout: Scenario = { | |||
There was a problem hiding this comment.
I renamed this one to better highlight the difference between "stepped" and "gradual" (they are both "progressive").
| getPalette() | ||
| ); | ||
| const [featureDefinitionLanguage, setFeatureDefinitionLanguage] = useState<DefinitionLanguage>(LANG_JSON); | ||
| const [isCustomScenario, setIsCustomScenario] = useState(false); |
There was a problem hiding this comment.
New useState to capture whether or not the user modified anything and we should encode the demo in the URL for sharing instead of just pointing to a pre-built scenario. Before we were doing some buggy comparisons.
| }); | ||
| }; | ||
|
|
||
| const handleButtonClick = (e: React.MouseEvent<HTMLButtonElement>) => { |
There was a problem hiding this comment.
Adding some better feedback on button clicks.
toddbaert
force-pushed
the
docs/fractional-updates
branch
from
024ca05 to
14c8ea2
Compare
* update public facing schema * update fractional docs * update playground demos Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
docs/fractional-updates
branch
from
14c8ea2 to
f9912aa
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
3 participants
Uh oh!
There was an error while loading. Please reload this page.