feat(csharp): added generator and integration tests #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriscoleman
force-pushed
the
feat/csharp-gen
branch
from
9aff6a4 to
2c9855d
Compare
kriscoleman
commented
Apr 6, 2025
kriscoleman
commented
Apr 6, 2025
kriscoleman
force-pushed
the
feat/csharp-gen
branch
4 times, most recently
from
e4c3479 to
3f5dab2
Compare
beeme1mr
approved these changes
Apr 7, 2025
askpt
reviewed
Apr 7, 2025
Member
askpt
left a comment
askpt
left a comment
There was a problem hiding this comment.
LGTM. I added a few small comments. Mostly nitpicks and potential improvements! Great contribution! 👍
Collaborator
Author
Adds a new generator for C# to create typesafe clients. This allows users to generate C# code based on feature flag definitions, streamlining integration with .NET applications. Includes necessary command-line flags, templates, and tests. Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
Adds a C# code generator integration test to ensure the generated C# code compiles correctly. This includes: - A new C# generator based on templates - Updates to the build process and documentation to support C# generation and testing - An integration test using Docker to compile the generated C# code - Fixes and adjustments to data type mappings for C# compatibility Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Kris Coleman <kris.blacksuitmedia@gmail.com> Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Kris Coleman <kris.blacksuitmedia@gmail.com> Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Kris Coleman <kris.blacksuitmedia@gmail.com> Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
…parate job Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
kriscoleman
force-pushed
the
feat/csharp-gen
branch
from
079bbb1 to
d14c764
Compare
Collaborator
Author
|
I just rebased, addressed conflicts, and worked on the enhancements from feedback. |
4 tasks
Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
- updated openfeature to 2.3.2 - introduced IServiceCollection and DI patterns - updated tests and expectations Signed-off-by: Kris Coleman <kriscodeman@gmail.com>
kriscoleman
force-pushed
the
feat/csharp-gen
branch
from
d14c764 to
197c8eb
Compare
beeme1mr
approved these changes
Apr 14, 2025
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kris Coleman <kris.blacksuitmedia@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kris Coleman <kris.blacksuitmedia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Contributes to #32
Notes
The C# generator follows the same pattern as the existing generators (Go, Node.js, React) and produces code compatible withnOpenFeature .NET SDK 2.0.0. The generator:
Follow-up Tasks
How to test
Build the CLI:
go buildGenerate a C# client using a sample manifest:
./cli generate csharp --manifest=sample/sample_manifest.json --namespace=MyApp.OpenFeatureRun the integration test to verify compilation:
make test-csharp(also, this is captured in a new github action workflow which should pass on this PR)