chore: bump Go to 1.26.3 and centralize CLI build in integration tests#251
chore: bump Go to 1.26.3 and centralize CLI build in integration tests#251erka wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project to Go 1.26.3 and refactors string building across multiple generators to use fmt.Fprintf for improved efficiency. The integration test framework has been optimized to build the OpenFeature CLI container once and share it across all language-specific tests, rather than rebuilding it per test. Additionally, reflection logic in the manifest comparison was simplified using the Fields iterator. Feedback suggests extracting the hardcoded Go version used for compatibility testing in the Go integration suite into a centralized constant to improve maintainability.
| @echo " ci - Run all CI checks locally (fmt, lint, test, verify-generate)" | ||
|
|
||
| # Tool versions | ||
| GOLANGCI_LINT_VERSION := v2.12.2 |
There was a problem hiding this comment.
Should we configure Renovate to manage this version?
There was a problem hiding this comment.
If we switch to mise to manage our developer tools, then we would get the additional benefit of Renovate PRs without additional configuration, as Renovate has mise support.
There was a problem hiding this comment.
mise is nice, but we need the GC and TC support for adoption. It would be a bad idea to start without that agreement.
- Bump go to 1.26.3 and update GoBaseImage accordingly - Use go 1.25.0 for integration go test as lowest version for compatibility - Move CLI build out of individual tests into shared buildOpenFeatureCLI - Bump golangci-lint to v2.12.2 and fix linter issues - Fix test/README.md and update new-generator.md Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the integration testing framework to build the CLI once and share it across tests, updates the project to Go 1.26.3, and optimizes string building using fmt.Fprintf. Feedback indicates several critical issues: the specified Go versions (1.25 and 1.26) and golangci-lint version (v2.12.2) are not valid released versions; the use of t.Fields() in the reflect package will cause compilation errors; and inconsistent indentation was found in the validation error format string.
3 participants
This PR