feat: add placeholder implementation for ModulationParameters, AntennaPattern, and VariableTransmitterParameters#78
Merged
leif81 merged 16 commits intoopen-dis:masterfrom Oct 2, 2025
Conversation
This removes the need to use the SpreadSpectrum record directly
These classes are defined in Annex C, and will be used by ModulationParameter (MP)
… class in dis7.py
This serves as a placeholder for unrecognised radios in ModulationParameters
… in ModulationParameters
Removed unused import of ModulationParameters.
Member
|
@ngjunsiang need more time or ready to merge? |
Contributor
Author
|
@leif81 it's ready 👍 will add future changes in a separate PR to keep this one easy to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransmitterPdu relies on the above for a complete implementation. These three classes are a challenge because:
This PR sets up a skeleton for handling such variable-size, variable-type records.
These changes enable TransmitterPdu to finally read the stream completely.
Future work
recordsnamespace as more types of records are addedIssues