Conversation
|
@kenny-holloway Thank-you for this. Ken and I had been discussing this PR earlier in the year via email. This PR was produced by a tool Ken had created to autogenerate the code base. Given it's a large change, we need to figure out best way that we could benefit from this, while minimizing impact on devs and users. |
leif81
left a comment
There was a problem hiding this comment.
The recommendation I have is to modify the code generator to output code that matches the existing open-dis-python API here. The resulting PR would be a smaller diff containing the changes the tool is able to find and fix for free.
@kenny-holloway what do you think?
|
I'll give my 2 cents here if that's okay. The codebase isn't quite stable yet and is likely to undergo more changes, especially since not all the functionality is in yet, and some/much refactoring is going to be needed to add the remaining functionality. It might perhaps be more useful to add the code generator itself, in a separate root directory or a separate repository if necessary. This would imply that future changes to the DIS7 codebase will need to take into account how the code generator works, and make appropriate changes to the code generator as well. |
The folder dis contains the entire DIS7 specification implemented in python. The code is generated by an updated version of the open-dis source generator.
I did not make the library of entity types for python yet.