Open
Conversation
added 2 commits
April 4, 2024 02:00
…pdu.length field before serializing it). Also fixed critical typos in FirePdu, DirectedEnergyFirePdu and ReceiverPdu: transmitterEntityId
Member
|
@VovaDev thank-you for the proposed change. A large change was merged today which has created a conflict in this PR. If you are still interested in proposing this change could you rebase your PR on the latest code in master to resolve the conflict. |
Contributor
|
I like this suggestion, and have an idea to make this easier so that the marshalled size does not need to be hardcoded. But I need to wrap up some other work on the refactoring first. |
This was referenced May 18, 2024
leif81
requested changes
Sep 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11.
Implemented marshalledSize for all classes (like in Java and C# implementations).
You still need to manually fill pdu.length field (aka
pdu.length = pdu.marshalledSize()), but at least you could do it effortlessly.Also includes some other critical fixes (typos in FirePdu, DirectedEnergyFirePdu and ReceiverPdu variable names).