Draft
Conversation
Contributor
Author
|
Also, this will resolve issue #52. |
Member
|
@crhowell3 this PR is marked draft. Did you have further changes you planned to add here? |
Contributor
Author
|
I will take another look at this issue to ensure that everything is ready as I intended. I will let you know if there is anything else that needs to be done. Sorry for such a long wait |
…s that shouldn't exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to take one more look over everything before I mark this as ready, but I have completed the bulk of the code base overhaul. I have included .clang-format and .clang-tidy configuration files in the top-level directory, and I ran
clang-tidyand Google'scpplinton all the source files to reformat them to follow Google Style conventions. I changed a lot of the primitive types to use the modern, standardizeduint_t/int_ttypes defined in<cstdint>, i.e.,unsigned int -> uint32_t, etc. I also changed all the DIS includes to use""instead of<>, as is convention for project-level include files.Again, there may be a few other things I need to tweak before this is ready, but I just wanted to go ahead and create the PR with my current progress.