feat(messages): include files field in message JSON output#120
Merged
Conversation
The Message struct was missing a Files field, so file attachment metadata from the Slack API (conversations.replies, conversations.history) was silently dropped during JSON unmarshalling. Messages with attachments appeared identical to plain text messages in JSON output. Add a File struct with the key fields (id, name, mimetype, filetype, size, url_private, url_private_download, permalink) and a Files field to Message so file data is preserved. Closes #119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filestruct andFilesfield toMessageso file attachment metadata from the Slack API is preserved in JSON outputmessages thread,messages history, and any other command returningMessageobjectsWhy
The
Messagestruct had noFilesfield, so file attachment data returned by the Slack API (conversations.replies,conversations.history) was silently dropped during JSON unmarshalling. A message like "see the screenshot below" appeared identical to a plain text message in--output json, losing important context for automated consumers.Test plan
TestRunThread_JSONIncludesFilesverifies files round-trip through JSON output0 issues)Closes #119