fix: prefer env var over keychain for API token resolution#118
Merged
Conversation
GetAPIToken() now checks SLACK_API_TOKEN env var before keychain, matching GetUserToken() behavior. This allows automation tools to inject their own tokens via env vars without conflicting with locally stored keychain credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetAPIToken()now checksSLACK_API_TOKENenv var before keychain, matching howGetUserToken()already worksGetTokenSource()updated to reflect the same precedenceWhy
Automation tools (like daemons) inject tokens via
SLACK_API_TOKENenv var, butGetAPIToken()checked keychain first and never reached the env var fallback. This made it impossible for subprocess-based tools to use their own bot tokens when the user also had a personal token stored in keychain.GetUserToken()already had the correct precedence (env var first), so this aligns the two functions.Test plan
SLACK_API_TOKEN=xoxb-test slck config showshows "from environment variable" for bot tokenslck config showstill shows keychain tokenslck whoamiworks with both env var and keychain tokens