Skip to content

feat(chocolatey): simplify packaging per reviewer feedback #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 1 commit into from
Feb 7, 2026
Merged

feat(chocolatey): simplify packaging per reviewer feedback #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/test-chocolatey.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ jobs:

# Binary is already in tools/ from CI build
Write-Host "salesforce-cli installed from local build for testing"

# Exclude non-executables from shimming
New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null
'@ | Set-Content tools/chocolateyInstall.ps1

- name: Pack Chocolatey package
Expand Down
5 changes: 0 additions & 5 deletions packaging/chocolatey/tools/chocolateyInstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ Install-ChocolateyZipPackage -PackageName $env:ChocolateyPackageName `
-Checksum $checksum `
-ChecksumType 'sha256'

# Exclude non-executables from shimming
# Chocolatey auto-creates shims for .exe files; .ignore files prevent shimming other files
New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null

Write-Host "salesforce-cli installed successfully. Run 'sfdc --help' to get started."
15 changes: 0 additions & 15 deletions packaging/chocolatey/tools/chocolateyUninstall.ps1
View file
Open in desktop

This file was deleted.