Skip to content

hotfix: Forgot to format#127

Closed
ysknsid25 wants to merge 2 commits into
open-circle:mainfrom
ysknsid25:hotfix/forgot-to-format
Closed

hotfix: Forgot to format#127
ysknsid25 wants to merge 2 commits into
open-circle:mainfrom
ysknsid25:hotfix/forgot-to-format

Conversation

@ysknsid25

@ysknsid25 ysknsid25 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

related: #115

I try to pnpm run format in my local, so many diffs are apeared. these are too noisy. Please resolve these differences before opening #115 🙏


Summary by cubic

Ran pnpm run format across the repo to normalize Tailwind class order and minor prop/class attribute ordering in UI components and routes. No functional changes; reduces noisy diffs and unblocks #115.

Written for commit 377c441. Summary will update on new commits.

Review in cubic

Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Copilot AI review requested due to automatic review settings June 1, 2026 14:23
@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown

@ysknsid25 is attempting to deploy a commit to the Open Circle Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. fix Smaller bug fix or improvement labels Jun 1, 2026
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This pull request systematically reorders Tailwind CSS utility classes across the entire codebase spanning all framework playgrounds (Preact, Qwik, Solid, Vue) and the website. Changes include reordering class declarations in component label elements, form inputs, layout containers, and global CSS utilities. Specific styling adjustments include repositioning the transparent border on spinner animations and adjusting decoration element positioning. No component logic, props, or visual behavior changes occur—only the sequence of utility class declarations is modified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'hotfix: Forgot to format' clearly and accurately describes the main change—a formatting pass using pnpm run format to normalize Tailwind class ordering and component styling across the repository.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description accurately relates to the changeset, clearly explaining that pnpm run format was run to normalize Tailwind class ordering and reduce noisy diffs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR standardizes Tailwind utility ordering across the website and all playground implementations, primarily by reordering class strings and @apply directives to be consistent.

Changes:

  • Reordered Tailwind utilities in shared styles (root.css) including the focus-ring utility and MDX styling.
  • Reordered Tailwind class strings across website routes/components for consistent formatting.
  • Applied the same class-order normalization across Vue/Solid/Qwik/Preact playground components and routes.

Reviewed changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/src/styles/root.css Reorders @apply utility lists (focus ring + MDX styling) for consistent Tailwind class ordering.
website/src/routes/playground/todos/index.tsx Reorders Tailwind classes on inputs for consistency.
website/src/routes/playground/nested/index.tsx Reorders Tailwind classes on inputs for consistency.
website/src/routes/playground/layout.tsx Reorders layout class list for consistency.
website/src/routes/index.tsx Reorders Tailwind classes in hero/FAQ section markup for consistency.
website/src/routes/blog/index.tsx Reorders main container class list for consistency.
website/src/routes/blog/(posts)/layout.tsx Reorders article/layout class lists for consistency.
website/src/routes/404.tsx Reorders main container class list for consistency.
website/src/routes/(legal)/layout.tsx Reorders main container class list for consistency.
website/src/hooks/useMDXComponents.tsx Reorders positioned toolbar classes for consistency.
website/src/components/TextLink.tsx Reorders focus-ring related classes for consistency.
website/src/components/Spinner.tsx Reorders border utility classes for consistency.
website/src/components/SideBar.tsx Reorders gradient overlay class list for consistency.
website/src/components/Radio.tsx Reorders label class list for consistency.
website/src/components/Property.tsx Reorders text styling classes for consistency.
website/src/components/PostList.tsx Reorders heading class list for consistency.
website/src/components/PostCover.tsx Reorders container/decoration classes for consistency.
website/src/components/Navigation.tsx Reorders background gradient classes for consistency.
website/src/components/Header.tsx Reorders header/nav class lists for consistency.
website/src/components/DocsLayout.tsx Reorders responsive padding classes for consistency.
website/src/components/DocSearch.tsx Reorders overlay/layout classes for consistency.
website/src/components/Debugger.tsx Reorders spacing utilities for consistency.
website/src/components/Checkbox.tsx Reorders label class list for consistency.
website/src/components/ApiList.tsx Reorders list container classes for consistency.
playgrounds/vue/src/views/TodosView.vue Reorders Tailwind classes on inputs for consistency.
playgrounds/vue/src/views/NestedView.vue Reorders Tailwind classes on inputs for consistency.
playgrounds/vue/src/components/Spinner.vue Reorders border utility classes for consistency.
playgrounds/vue/src/components/Radio.vue Reorders label class list for consistency.
playgrounds/vue/src/components/Checkbox.vue Reorders label class list for consistency.
playgrounds/solid/src/routes/todos/index.tsx Reorders Tailwind classes on inputs for consistency.
playgrounds/solid/src/routes/nested/index.tsx Reorders Tailwind classes on inputs for consistency.
playgrounds/solid/src/components/Spinner.tsx Reorders border utility classes for consistency.
playgrounds/solid/src/components/Radio.tsx Reorders label class list for consistency.
playgrounds/solid/src/components/Checkbox.tsx Reorders label class list for consistency.
playgrounds/qwik/src/routes/todos/index.tsx Reorders Tailwind classes on inputs for consistency.
playgrounds/qwik/src/routes/nested/index.tsx Reorders Tailwind classes on inputs for consistency.
playgrounds/qwik/src/components/Spinner.tsx Reorders border utility classes for consistency.
playgrounds/qwik/src/components/Radio.tsx Reorders label class list for consistency.
playgrounds/qwik/src/components/Checkbox.tsx Reorders label class list for consistency.
playgrounds/preact/src/routes/todos/index.tsx Reorders Tailwind classes on inputs for consistency.
playgrounds/preact/src/routes/nested/index.tsx Reorders Tailwind classes on inputs for consistency.
playgrounds/preact/src/components/Spinner.tsx Reorders border utility classes for consistency.
playgrounds/preact/src/components/Radio.tsx Reorders label class list for consistency.
playgrounds/preact/src/components/Checkbox.tsx Reorders label class list for consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 44 files

Re-trigger cubic

Signed-off-by: ysknsid25 <kengo071225@gmail.com>
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 1, 2026
@ysknsid25

Copy link
Copy Markdown
Contributor Author

I'm so sorry🙇🙇

The issue was caused by a difference in pnpm versions in my local environment. It was my mistake. I'm closing this pull request.

@ysknsid25 ysknsid25 closed this Jun 1, 2026
@ysknsid25 ysknsid25 deleted the hotfix/forgot-to-format branch June 1, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Smaller bug fix or improvement size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants