-
Notifications
You must be signed in to change notification settings - Fork 9
[feature] Automatic props table for components #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…-docs into feature/auto-props # Conflicts: # package-lock.json # package.json # src/components/PropsTable/PropsTable.jsx # src/content/docs/components/collapsible/readme.mdx
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ykadosh/webrix-docs/k1RVqqRb7HfWFsSov4S8CyjqPytE |
| padding: 0 7px; | ||
| margin: 0; | ||
| font-size: .8em; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not write this, but copied dolve's file
| net: false, | ||
| path: require.resolve('path-browserify'), | ||
| process: require.resolve('process/browser'), | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are imperative for react-docgen to be able to be imported correctly.
(Took me hours to get this to work properly)
| ], | ||
| }, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not change all these above modifications, maybe the linter did this, not sure.
Maybe it was like this already when I copied dolev's branch
webpack/webpack.js
Outdated
| ] | ||
| new webpack.ProvidePlugin({ | ||
| process: 'process', | ||
| Buffer: ['buffer', 'Buffer'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, these are imperative for react-docgen to be able to be imported correctly.
(Took me hours to get this to work properly)
collapsiblecomponent.If approved, all other files should use this automatic method of extraction.
Usage (in
mdxfile)Currently it lazy-loads the file automatically inside
PropsTable.jsxwhere the path is for thewebrixproject folder which is a sibling to thiswebrix-docsfolderThis should be taken into account in the pipeline (solution yet to to be finalized)