Add ParentNode and fix children implementation#46
Open
davispuh wants to merge 1 commit intoopal:masterfrom
Open
Add ParentNode and fix children implementation#46davispuh wants to merge 1 commit intoopal:masterfrom
davispuh wants to merge 1 commit intoopal:masterfrom
Conversation
davispuh
force-pushed
the
fix_children
branch
from
cccb744 to
bd1773d
Compare
Member
There was a problem hiding this comment.
Was this removed on purpose? I still want that available.
Author
There was a problem hiding this comment.
I removed it because I wasn't sure if it will work as children is read-only, but seems individual elements can still be removed. Also previously it would remove all child nodes, but now this would remove only element nodes. What is expected behavior?
Member
|
Regarding the children method, I think this implementation should follow Nokogiri for an expected behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look at https://developer.mozilla.org/en-US/docs/Web/API/ParentNode
ParentNode.childrenreturns only element nodes without text nodes unlikeNode.childNodeswhich includes all Nodes and so current implementation is wrong.Note that I haven't really tested this yet but I think it should work, also there aren't tests for this.