Skip to content

Implement HTML/CSS design with responsive layout#8

Open
frangirona86 wants to merge 1 commit intoooptimo:mainfrom
frangirona86:franciscogirona
Open

Implement HTML/CSS design with responsive layout#8
frangirona86 wants to merge 1 commit intoooptimo:mainfrom
frangirona86:franciscogirona

Conversation

@frangirona86
Copy link
Copy Markdown

Descripción

He implementado el diseño de Figma proporcionado usando HTML y SCSS.

Lo que incluye:

  • Header sticky con la barra de búsqueda y el logo "ooptimo."
  • Sección principal con el texto destacado "era digital" en verde
  • Botón de contacto con efecto hover
  • Footer con 4 columnas: información de la empresa, datos de contacto, enlaces legales e iconos de redes sociales
  • Diseño responsive para móvil, tablet y escritorio

Decisiones técnicas:

  • Usé SCSS con variables para colores y tipografías (Georgia y Futura)
  • Los iconos de redes sociales son de Font Awesome (CDN)
  • Breakpoints en 980px, 768px y 480px
  • Seguí la paleta de colores del diseño: #202F66, #6ED5B8 y #FFFFFF

Copy link
Copy Markdown

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments (6)
  • css/main.css (1-1) In the 768px media query, the `.subtitle` class has `padding-top:50px` which isn't present in the default styles. This could cause unexpected layout shifts when resizing the browser. Consider harmonizing these styles or using a different approach to maintain consistent spacing.
  • css/main.css (1-1) The CSS uses `font-family: Futura, sans-serif;` in several places, but Futura is not a web-safe font and might not be available on all systems. Consider adding more fallback fonts or using a web font service to ensure consistent rendering across different devices.
  • src/scss/main.scss (283-283) The `padding-top: 50px;` added to the `.subtitle` class in the mobile media query (line 283) might cause unexpected spacing issues. This property doesn't exist in the desktop version, which could lead to inconsistent vertical spacing. Consider either removing this property or adding an equivalent padding to the desktop version for consistency.
  • src/scss/main.scss (377-378) The social media icons are inconsistently sized between breakpoints. They're 30px on desktop (lines 198-199) but 35px on mobile (lines 377-378). Typically, UI elements are the same size or smaller on mobile devices, not larger. Consider keeping the icons the same size or making them smaller on mobile.
  • src/scss/main.scss (62-62) The `.main` element has a fixed height of 873px (line 62) which could cause content overflow issues on smaller screens or with varying content amounts. While you correctly use `height: auto` with `min-height: 100vh` in the mobile version (lines 274-275), consider applying this more flexible approach to all screen sizes to prevent potential overflow problems.
  • css/main.css (1-1) The main section has a fixed height of 873px which could cause content overflow issues. Consider using `min-height: 873px; height: auto;` instead of just `height: 873px;` to accommodate varying content lengths.

💡 To request another review, post a new comment with "/windsurf-review".

<p>Connectant les companyes amb els seus<br> clients com mai abans ho havien fet.</p>
</div>

<button class="btn-contact">Contactar</button>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contact button is missing a type attribute. For standalone buttons not in a form, add type="button" for better accessibility and to prevent unexpected behavior in some browsers.

Suggested change
<button class="btn-contact">Contactar</button>
<button type="button" class="btn-contact">Contactar</button>

<title>Job Application HTML Tests — ooptimo</title>
<link rel="stylesheet" href="css/main.css">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.1/css/all.min.css">
<meta name="description" content="">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meta description tag is empty. For better SEO, add a concise description of the page content (ideally 150-160 characters).

@@ -1,2 +1,2 @@

*{margin:0;padding:0;box-sizing:border-box}body{font-family:Georgia,serif}.header{width:100%;height:112px;position:sticky;top:0;padding-top:20px}.search{width:934px;height:112px;margin:0 auto;border-radius:100px;background:#6ed5b8;position:relative}.logo{padding:17px 32px;font-size:40px;font-weight:700;color:#202f66;display:flex;align-items:center;height:100%}.main{width:100%;height:873px;background:linear-gradient(180deg,#d4d6e1 0,#202f66 68%)}.section-primary{max-width:940px;margin:0 auto;padding-top:150px}.text-one{font-family:Georgia,serif;font-weight:400;font-size:60px;line-height:107%;text-align:center;color:#fff}.text-one p{margin:0}.era-digital{color:#6ed5b8;font-weight:700}.subtitle{font-family:Georgia,serif;font-size:20px;line-height:140%;text-align:center;color:#fff;margin-top:30px}.subtitle p{margin:0}.btn-contact{display:block;margin:55px auto 0;width:203.89px;height:69.31px;padding:17.33px 55.45px;background-color:#6ed5b8;color:#202f66;font-family:Georgia,serif;font-size:18px;font-weight:700;border:none;border-radius:8.66px;cursor:pointer;transition:background-color .3s ease,color .3s ease}.btn-contact:hover{background-color:#fff;color:#6ed5b8}.footer{background-color:#fff;width:100%}.footer__content{max-width:1200px;margin:0 auto;padding:60px 20px;display:grid;grid-template-columns:repeat(4,1fr);gap:40px}.footer__column{display:flex;flex-direction:column}.footer__logo{font-family:Georgia,serif;font-size:32px;font-weight:700;color:#202f66;margin-bottom:20px}.footer__copyright{font-family:Futura,sans-serif;font-size:12px;color:#202f66;line-height:1.6}.footer__title{font-family:Georgia,serif;font-size:20px;font-weight:100;color:#202f66;margin-bottom:20px}.footer__text{font-family:Futura,sans-serif;font-size:12px;color:#202f66;margin-bottom:8px}.footer__link{font-family:Futura,sans-serif;font-size:12px;color:#202f66;text-decoration:underline;margin-bottom:8px;display:block}.footer__link:hover{opacity:.7}.footer__social{display:flex;gap:15px}.footer__social-link{width:30px;height:30px;border-radius:50%;background-color:#202f66;color:#fff;display:flex;align-items:center;justify-content:center;text-decoration:none;font-size:20px;transition:opacity .3s ease}.footer__social-link:hover{opacity:.7}.footer__social-link i{display:flex;align-items:center;justify-content:center}.footer__bottom{background-color:#202f66;padding:30px 20px;text-align:center}.footer__bottom-logo{font-family:Georgia,serif;font-size:32px;font-weight:700;color:#fff;margin:0}@media (max-width:980px){.search{width:90%}.text-one{font-size:36px}.section-primary{width:90%;padding-top:170px;padding-bottom:60px}}@media (max-width:768px){.header{height:80px;padding-top:10px}.search{height:80px}.logo{font-size:28px;padding:10px 20px}.main{height:auto;min-height:100vh}.subtitle{font-size:20px;margin-top:20px;padding-top:50px}.btn-contact{width:auto;height:auto;padding:15px 40px;font-size:16px;margin-top:25px}.footer__content{grid-template-columns:1fr;gap:30px;padding:40px 20px}.footer__logo{font-size:28px;text-align:center}.footer__title{font-size:18px;margin-bottom:15px;text-align:center}.footer__bottom{padding:20px;text-align:center}.footer__bottom-logo{font-size:24px;text-align:center}.footer__social{justify-content:center}.footer__copyright{text-align:center}.footer__link{text-align:center}.footer__text{text-align:center}}@media (max-width:480px){.header{height:70px}.search{height:70px}.logo{font-size:24px}.text-one{font-size:28px}.btn-contact{padding:12px 30px;font-size:14px}.footer__logo{font-size:24px}.footer__title{font-size:16px}.footer__social-link{width:35px;height:35px;font-size:16px}}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search bar has a fixed width of 934px which could cause horizontal overflow on screens just slightly smaller than this width. Consider using max-width: 934px; width: 100%; instead of just width: 934px; for better responsiveness between breakpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant