Open
Conversation
There was a problem hiding this comment.
Other comments (10)
-
src/css/base.css (11-12)
The font format value is incorrect. For TTF files, use 'truetype' instead of 'ttf'.
src: url("../../assets/fonts/futura-medium/FUTURAMEDIUM.TTF") format("truetype"); -
src/css/base.css (16-20)
The `@theme` directive is not valid CSS. For Tailwind theme customization, you should either:
- Use CSS custom properties within a
:rootselector - Define theme colors in your tailwind.config.js file
For example:
:root { --color-ooptimo-dark-blue: #202F66; --color-ooptimo-mint: #6ED5B8; --color-ooptimo-light-gray: #D2D5E0; }
Or in tailwind.config.js:
module.exports = { theme: { extend: { colors: { 'ooptimo-dark-blue': '#202F66', 'ooptimo-mint': '#6ED5B8', 'ooptimo-light-gray': '#D2D5E0' } } } }
- Use CSS custom properties within a
-
css/main.css (511-511)
The @font-face declarations use `format("ttf")` which is incorrect. The proper format string for TTF files should be `format("truetype")`.
src: url("../../assets/fonts/georgia-2/georgia.ttf") format("truetype"); - css/main.css (346-346) The `.rounded-full` class uses `border-radius: calc(infinity * 1px);` which is not valid CSS. For a fully rounded element, you should use `border-radius: 9999px;` or `50%` instead.
- package.json (17-17) There appears to be an incorrect package reference: `@tailwindcss/postcss` version `4.1.15` doesn't exist in npm registry. Did you mean to use just `tailwindcss` (which is already included) or perhaps `@tailwindcss/forms` or another official Tailwind plugin?
-
index.html (19-19)
The sticky navigation in the header needs a z-index to ensure it stays above other content when scrolling. Consider adding a z-index value:
<div class="w-full max-w-6xl flex justify-center mb-10 sticky top-3 z-50"> - css/main.css (510-515) The font file paths in the @font-face declarations use `../../assets/fonts/` which navigates up two directory levels from the css folder. This might cause issues if the directory structure changes or if the files are served from a different location in production. Consider using paths relative to the root or using absolute paths.
-
css/main.css (515-515)
The same format issue exists for the Futura-medium font declaration.
src: url("../../assets/fonts/futura-medium/FUTURAMEDIUM.TTF") format("truetype"); -
index.html (36-36)
The contact button has conflicting text size classes (`text-xl` and `text-lg`). Remove one of them to ensure consistent styling:
class="inline-block mt-10 py-7 px-18 bg-ooptimo-mint text-ooptimo-dark-blue text-lg font-[700] rounded-lg shadow-lg hover:bg-white hover:text-ooptimo-mint transition duration-300"> -
index.html (75-75)
Remove the extra space before the closing bracket in the social media icon image attributes:
<img src="./assets/images/Facebook.png" alt="Facebook icon" class="w-[38px] h-[38px]">
1 file skipped due to size limits:
- package-lock.json
💡 To request another review, post a new comment with "/windsurf-review".
| "postcss": "^8.4.27", | ||
| "postcss-cli": "^10.1.0", | ||
| "postcss-import": "^15.0.0", | ||
| "tailwindcss": "^4.1.15" |
There was a problem hiding this comment.
The specified version of tailwindcss (4.1.15) doesn't exist. The current stable version is around 3.x. Please update to a valid version like ^3.3.0 or the latest available version.
Comment on lines
+3
to
+5
| 'postcss-import': {}, | ||
| '@tailwindcss/postcss': {}, | ||
| autoprefixer: {}, |
There was a problem hiding this comment.
The Tailwind CSS plugin is incorrectly referenced. It should be 'tailwindcss' instead of '@tailwindcss/postcss'.
Suggested change
| 'postcss-import': {}, | |
| '@tailwindcss/postcss': {}, | |
| autoprefixer: {}, | |
| 'postcss-import': {}, | |
| 'tailwindcss': {}, | |
| autoprefixer: {}, |
Comment on lines
+5
to
+6
| src: | ||
| url("../../assets/fonts/georgia-2/georgia.ttf") format("ttf"); |
There was a problem hiding this comment.
The font format value is incorrect. For TTF files, use 'truetype' instead of 'ttf'.
Suggested change
| src: | |
| url("../../assets/fonts/georgia-2/georgia.ttf") format("ttf"); | |
| src: | |
| url("../../assets/fonts/georgia-2/georgia.ttf") format("truetype"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Se eliminó el pipeline basado en Gulp y se reemplazó por una configuración más ligera con PostCSS y Tailwind CSS, con el objetivo de simplificar la cadena de herramientas.
Gracias a Tailwind, se reduce significativamente la cantidad de código CSS que es necesario escribir, mientras que PostCSS se encarga de eliminar las clases no utilizadas durante el proceso de compilación, generando así un archivo CSS final más optimizado y de menor tamaño.