Conversation
sdsantos
requested changes
Oct 14, 2025
| val ip: String?, | ||
| val asn: String?, | ||
| val countryCode: String?, | ||
| val geoIpdb: String?, |
Contributor
There was a problem hiding this comment.
Why do we need to get the geoIpDb from the engine?
Member
Author
There was a problem hiding this comment.
To determine which version of geoIPDB the engine is currently working with.
aanorbel
force-pushed
the
feat/dynamic-geoipdb
branch
2 times, most recently
from
af697b7 to
eef3dbc
Compare
aanorbel
force-pushed
the
feat/dynamic-geoipdb
branch
from
eef3dbc to
b5322c8
Compare
aanorbel
changed the title
geoipdb from path
sdsantos
requested changes
Nov 5, 2025
Contributor
sdsantos
left a comment
sdsantos
left a comment
There was a problem hiding this comment.
Some other issues:
a) We're not cleaning old version of the geoIp database after we download an update
b) GeoIP databases will count for storage usaged, but they are not cleared when the clean storage (maybe this is what we want, but just wanted to make sure)
c) The fetch is running on app start, and therefore on any instrumented test we have. It should be disabled for most tests I imagine.
Comment on lines
+29
to
+30
| const val GEOIP_DB_VERSION_DEFAULT: String = "20250801" | ||
| const val GEOIP_DB_REPO: String = "aanorbel/oomplt-mmdb" |
Contributor
There was a problem hiding this comment.
These constants could be private.
| return Success(null) | ||
| } else { | ||
| val url = buildGeoIpDbUrl(latestVersion) | ||
| val target = "$cacheDir/$latestVersion.mmdb" |
Contributor
There was a problem hiding this comment.
Is the cacheDir the place we really want for these files? Is some systems, cache directories can be deleted periodically.
aanorbel
force-pushed
the
feat/dynamic-geoipdb
branch
from
b1d98df to
305a640
Compare
sdsantos
approved these changes
Nov 17, 2025
Comment on lines
+43
to
+47
| val currentTimeMillis = Clock.System.now().toEpochMilliseconds() | ||
| val oneDayInMillis = 24 * 60 * 60 * 1000L | ||
| val timeSinceLastCheck = currentTimeMillis - lastCheckMillis | ||
|
|
||
| if (timeSinceLastCheck < oneDayInMillis) { |
Contributor
There was a problem hiding this comment.
You can take advantage of kotlin.time.Duration to make this more clear:
if (Clock.System.now() - Instant.fromEpochMilliseconds(lastCheckMillis) < 1.days) {
}
f0d6556 to
4ccfdd8
Compare
sdsantos
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ooni/probe#2868