Skip to content

test(oocana): compare JSON as dicts instead of strings in test_data.py #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leavesster merged 1 commit into from
Feb 2, 2026
Merged

test(oocana): compare JSON as dicts instead of strings in test_data.py #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions oocana/tests/test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import unittest
from oocana import data
from json import dumps as json_dumps
from json import dumps as json_dumps, loads as json_loads

class TestData(unittest.TestCase):

Expand Down Expand Up @@ -63,13 +63,15 @@ def test_dataclass_dumps(self):

block_info = data.BlockInfo(**block_info_dict)
serialize_block_info = data.dumps(block_info)
self.assertEqual(serialize_block_info, '{"session_id": "session_id_one", "job_id": "job_id_one", "stacks": ["stack1", "stack2"], "block_path": "block_path_one"}')
# Compare as dicts to avoid field order dependency
expected = {"session_id": "session_id_one", "job_id": "job_id_one", "stacks": ["stack1", "stack2"], "block_path": "block_path_one"}
self.assertEqual(json_loads(serialize_block_info), expected)

list_serialize_block_info = data.dumps([block_info])
self.assertEqual(list_serialize_block_info, '[{"session_id": "session_id_one", "job_id": "job_id_one", "stacks": ["stack1", "stack2"], "block_path": "block_path_one"}]')
self.assertEqual(json_loads(list_serialize_block_info), [expected])

key_serialize_block_info = data.dumps({"key": block_info})
self.assertEqual(key_serialize_block_info, '{"key": {"session_id": "session_id_one", "job_id": "job_id_one", "stacks": ["stack1", "stack2"], "block_path": "block_path_one"}}')
self.assertEqual(json_loads(key_serialize_block_info), {"key": expected})

with self.assertRaises(TypeError):
json_dumps(block_info)
Expand All @@ -85,7 +87,9 @@ def test_dataclass_dumps_with_none(self):

block_info = data.BlockInfo(**block_info_dict)
serialize_block_info = data.dumps(block_info.block_dict())
self.assertEqual(serialize_block_info, '{"session_id": "session_id_one", "job_id": "job_id_one", "stacks": ["stack1", "stack2"]}')
# Compare as dicts to avoid field order dependency
expected = {"session_id": "session_id_one", "job_id": "job_id_one", "stacks": ["stack1", "stack2"]}
self.assertEqual(json_loads(serialize_block_info), expected)

with self.assertRaises(TypeError):
json_dumps(block_info)
Loading