Typecheck test files without adding test libraries#22
Merged
Conversation
The test files were not being type-checked because tsconfig.json only included src/**/*.ts. This meant invalid properties on Pipeline objects would silently pass through to YAML output. Add tsconfig.test.json that extends the base config but includes test files, and update the test script to run tsc before node --test. This ensures TypeScript's excess property checking catches invalid keys. Fixes #21
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test files were not being type-checked because
tsconfig.jsononly includedsrc/**/*.ts. This meant invalid properties on Pipeline objects would silently pass through to YAML output.Add
tsconfig.test.jsonthat extends the base config but includes test files, and update the test script to runtscbeforenode --test. This ensures TypeScript's excess property checking catches invalid keys.Fixes #21