Uncomment toast,clipboard,netinfo modules in MainReactPackage#45
Open
AbilashK wants to merge 1 commit intooney:masterfrom
Open
Uncomment toast,clipboard,netinfo modules in MainReactPackage#45AbilashK wants to merge 1 commit intooney:masterfrom
AbilashK wants to merge 1 commit intooney:masterfrom
Conversation
Author
|
@oney Is there any reason why these modules were commented out? |
AbilashK
force-pushed
the
main-reactpackage-fix
branch
from
4cbd30a to
bb4c8ea
Compare
|
@oney Is there any reason why these modules were commented out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we do conditional requiring for components based on app state(killed or running) it is not possible to separate modules like toast inside react-native like we do for third party modules. So the base react-native package should include all the default modules. Should fix #40