Add UBIFS decryption support (fscrypt)#108
Merged
qkaiser merged 1 commit intoonekey-sec:mainfrom Jun 4, 2025
Merged
Conversation
qkaiser
changed the title
qkaiser
requested changes
Apr 29, 2025
Contributor
qkaiser
left a comment
qkaiser
left a comment
There was a problem hiding this comment.
First pass. Let's pair program.
Contributor
Author
|
Fixed all comments and fixed all files. Decryption also works with list. And unencrypted images also working :) |
qkaiser
reviewed
May 5, 2025
e3krisztian
reviewed
May 27, 2025
e3krisztian
reviewed
May 27, 2025
elektrischermoench
force-pushed
the
main
branch
2 times, most recently
from
2a76c17 to
c0b9ec1
Compare
e3krisztian
requested changes
May 28, 2025
e3krisztian
requested changes
Jun 2, 2025
elektrischermoench
force-pushed
the
main
branch
6 times, most recently
from
528331e to
aec7558
Compare
e3krisztian
approved these changes
Jun 3, 2025
qkaiser
requested changes
Jun 4, 2025
Contributor
qkaiser
left a comment
qkaiser
left a comment
There was a problem hiding this comment.
Code looks good to me. Please make sure your patch is clean and only contains relevant changes. You have a bunch of single line addition or removal, sometimes even adding whitespaces that are dangling around. I left a comment for each of them.
Clean it up and then we merge :)
qkaiser
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ubifs fscrypt decription for V1 policies