Skip to content

Conversation

@YO4
Copy link
Contributor

@YO4 YO4 commented Jan 6, 2026

  • Add RubyInstaller2 logo and help command guidance to irb start screen.
  • Make console reading more robust.
  • Improve console window size calculation

YO4 added 4 commits January 6, 2026 21:22
irb with the RubyInstaller2 logo and help command guidance.
also clear the screen when it seems appropriate.
When selecting while a large amount of console input is arriving at high rate,  the console read thread may continue reading.
For example, hold down the cursor keys to move the mouse cursor and click while doing so.
To address this, only perform console input when necessary.
reserve lines for the headline.
handle cases when the console is too small.
@larskanis
Copy link
Member

Hey this is great, thank you for working on this. The startmenu.rb is my ad-hoc solution for shrinking the number of icons to only one, in order to meet the Microsoft store requirements. It shall run without external dependencies.

@echo off

set dir=%~dp0
ruby -r "%dir:\=/%../lib/ruby_installer/runtime/console_ui" "%dir:\=/%../resources/files/startmenu.rb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruby -I "%dir:\=/%../lib" "%dir:\=/%../resources/files/startmenu.rb"
is enough to run the startmenu in the project tree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only concerned about console_ui, but your suggestion looks smarter.
ruby_installer/runtime/colors.rb is loaded from outside the repository, so a note will be added.

if @base_console_input_mode
IO.console.write "."
setconsolemode(@base_console_input_mode | ENABLE_EXTENDED_FLAGS)
IO.console.write "+"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this debug code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm embarrassed.
Would it be okay if I stash it away in the end?

YO4 added 3 commits January 7, 2026 20:41
Added a note regarding other files that are loaded.
It seems the mouse can't be used when using conhost (not Windows Terminal).
Running `start ruby startmenu.rb` from within the terminal causes identification to fail, but worrying about that is probably pointless.
@YO4
Copy link
Contributor Author

YO4 commented Jan 7, 2026

In fact, on my end, the screen clearing output is being ignored in ButtonMatrix#repaint. The cause has not been identified.

Even so, I believe this has improved accessibility for users at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants