Skip to content

๐ŸŽจErrorCode ๊ธฐ๋ฐ˜ ๊ณตํ†ต ์‘๋‹ต ๋ฐ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๋ฆฌํŒฉํ„ฐ๋ง#63

Open
mango0422 wants to merge 12 commits into
one-day-one-problem:developfrom
mango0422:refactor/errorcode
Open

๐ŸŽจErrorCode ๊ธฐ๋ฐ˜ ๊ณตํ†ต ์‘๋‹ต ๋ฐ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๋ฆฌํŒฉํ„ฐ๋ง#63
mango0422 wants to merge 12 commits into
one-day-one-problem:developfrom
mango0422:refactor/errorcode

Conversation

@mango0422
Copy link
Copy Markdown

๐Ÿš€ ๊ฐœ์š”

enum ํƒ€์ž…์œผ๋กœ ์—๋Ÿฌ์ฝ”๋“œ ๋ฐ ๋ฉ”์‹œ์ง€๋ฅผ ๋ถ„๋ฆฌํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ” ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • ErrorCode enum ๋„์ž…์œผ๋กœ ์„ฑ๊ณต/์—๋Ÿฌ ๋ฉ”์‹œ์ง€ + HTTP ์ƒํƒœ ์ฝ”๋“œ ์ค‘์•™ ๊ด€๋ฆฌ
  • BaseResponse ๊ตฌ์กฐ๋ฅผ statusCode, message, data๋กœ ๋‹จ์ˆœํ™”ํ•˜๊ณ  ErrorCode์™€ ์—ฐ๋™
  • Controller/GlobalExceptionHandler/์ปค์Šคํ…€ ์˜ˆ์™ธ๊ฐ€ ๋ชจ๋‘ ErrorCode ๊ธฐ๋ฐ˜์œผ๋กœ ์‘๋‹ตํ•˜๋„๋ก ๋ณ€๊ฒฝ

โณ ์ž‘์—… ๋‚ด์šฉ

  • GlobalExceptionHandler์— error(ErrorCode, message) ํ—ฌํผ ์ถ”๊ฐ€ ๋ฐ ์ „์—ญ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๋กœ์ง ํ†ต์ผ
  • ProblemController, SubmissionController, UserController, TokenController ์‘๋‹ต์„ ErrorCode.xxx.toResponseEntity(data)๋กœ ๋ณ€๊ฒฝ
  • ProblemNotFoundException, InvalidAnswerFormatException, SubmissionNotFoundException์— ErrorCode ํ•„๋“œ ์ถ”๊ฐ€ ๋ฐ ๊ธฐ๋ณธ ๋ฉ”์‹œ์ง€ enum์—์„œ ์กฐํšŒํ•˜๋„๋ก ์ˆ˜์ •

๐Ÿ“ ๋…ผ์˜์‚ฌํ•ญ

  • BaseResponse.isSuccess ํ•„๋“œ ์ œ๊ฑฐ OK ์—ฌ๋ถ€
    • ๊ธฐ์กด ํ”„๋ก ํŠธ์—”๋“œ๊ฐ€ isSuccess๋ฅผ ์ฐธ์กฐํ•˜์ง€ ์•Š๊ณ  statusCode๋งŒ์œผ๋กœ ์ฒ˜๋ฆฌํ•ด๋„ ๋˜๋Š”์ง€ ํ™•์ธ ํ•„์š”

namsh1125 and others added 9 commits March 23, 2025 20:10
โ€ฆ-bug-submissions-ํ…Œ์ด๋ธ”์—์„œ-user_id๊ฐ€-null๋กœ-์ €์žฅ๋˜๋Š”-๋ฌธ์ œ

โœจ ํŠน์ • API ์—”๋“œํฌ์ธํŠธ์— ์ธ์ฆ ์š”๊ตฌ ์ถ”๊ฐ€
โ€ฆvelop

๐Ÿš€ Merge 'develop' branch into 'main' branch
โ€ฆvelop

๐Ÿš€ Merge 'develop' branch into 'main' branch
โ€ฆx/problem-solved-count

๐Ÿ› ๋ฌธ์ œ ํ•ด๊ฒฐ ์‚ฌ์šฉ์ž ์ˆ˜ ์ง‘๊ณ„ ๋กœ์ง์„ ์ˆ˜์ •ํ•˜์—ฌ ๋ฌธ์ œ ํ•ด๊ฒฐ ์‚ฌ์šฉ์ž ์ˆ˜๊ฐ€ ์ •ํ™•ํ•˜๊ฒŒ ์ €์žฅ๋˜๋„๋ก ๊ฐœ์„ 
โ€ฆvelop

๐Ÿš€ Merge 'develop' branch into 'main' branch
โ€ฆ-improve-๋ฌธ์ œ-๋ชฉ๋ก-์กฐํšŒ-api-์„ฑ๋Šฅ-๊ฐœ์„ 

โšก DB ์ธ๋ฑ์‹ฑ์„ ํ†ตํ•œ ๋ฌธ์ œ ๋ชฉ๋ก API ์„ฑ๋Šฅ ๊ฐœ์„ 
โ€ฆtfix/cicd

๐Ÿš‘ SonarQube ์‚ฌ๋ง์œผ๋กœ CI/CD ํŒŒ์ดํ”„๋ผ์ธ ์ˆ˜์ •
@mango0422 mango0422 changed the base branch from main to develop November 19, 2025 13:57
Copy link
Copy Markdown
Contributor

@namsh1125 namsh1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onCreate, onBadRequest๋ฅผ ์ง€์šฐ๊ณ  error ๋ฉ”์„œ๋“œ๋ฅผ ๋งŒ๋“œ์…จ์œผ๋ฉด onUnauthorized, onForbidden๋„ error ๋ฉ”์„œ๋“œ๋กœ ํ†ตํ•ฉํ•˜๋Š” ๊ฒƒ์ด ์ข‹์•„ ๋ณด์ž…๋‹ˆ๋‹ค :)

Copy link
Copy Markdown
Contributor

@namsh1125 namsh1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProblemNotFoundException, SubmissionNotFoundException์™€ ๊ฐ™์ด 8๋ฒˆ์งธ ์ค„์— ํ•œ ์ค„ ๋„์šฐ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค :)

Copy link
Copy Markdown
Contributor

@namsh1125 namsh1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!๐Ÿ‘

@mango0422 mango0422 marked this pull request as ready for review November 28, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants