Skip to content
Draft

v3 #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
148 commits
Select commit Hold shift + click to select a range
241b4ca
:bookmark: (v2.2.1) update version
Joachim-Lebrun Feb 22, 2024
9b8d73b
:bookmark: (v2.2.1) update version (#94) (#102)
Joachim-Lebrun Jun 27, 2024
ddfac31
OID-49 update solidity version with caret on interfaces (#101)
pgonday Jun 27, 2024
d868d57
:bookmark: version 2.2.2-beta1
Joachim-Lebrun Jun 27, 2024
d94822b
Merge branch 'main' into develop
Joachim-Lebrun Jun 27, 2024
7c9304a
OID-49 Also add solidity version caret for IIdFactory
pgonday Jun 27, 2024
65db02a
Update version to 2.2.2-beta2
pgonday Jun 27, 2024
08cca6f
basic version
Feb 11, 2025
6754b5e
functional version
Feb 11, 2025
aca3ae5
add naspects and refactor
Feb 11, 2025
6bdf18f
remove title
Feb 11, 2025
73f9b70
refactor to topic name
Feb 11, 2025
411ce4f
improve readability
Feb 12, 2025
edca35d
delete outdated link
Feb 12, 2025
42babee
name return for getter
Feb 12, 2025
0c1416b
Merge pull request #108 from onchain-id/bt-564-map-topic-to-string
Joachim-Lebrun Feb 24, 2025
e77d466
⬆️ Update Solidity and Ethers versions
pgonday Apr 8, 2025
efbbee0
🔀 Update after rebase to develop
pgonday Apr 10, 2025
320b2f2
♻️ Use Custom Errors
pgonday Apr 9, 2025
3ae2bd6
🔀 Update after rebase on develop
pgonday Apr 10, 2025
4fbe7c4
♻️ Various updates
pgonday Apr 10, 2025
37ecf3c
🔀 Update after rebase on develop
pgonday Apr 10, 2025
6659626
Merge pull request #110 from onchain-id/update-solidity-ethers
Joachim-Lebrun Apr 10, 2025
b050e20
Merge pull request #114 from onchain-id/custom-errors-dev
Joachim-Lebrun Apr 10, 2025
553b690
✨ ClaimIssuer factory
pgonday Apr 11, 2025
d4a7fd0
✨ ClaimIssuer proxy, factory impl update
pgonday Apr 23, 2025
9bacbe9
wip
May 22, 2025
44e9424
add tests
May 22, 2025
fd724cb
add proxy tests
May 22, 2025
b018367
add consistent formatting to authorize upgrade
May 22, 2025
f6c06d0
add docs for topic
May 23, 2025
f26e5ca
:rotating_light: fix lint and visibility
Joachim-Lebrun Jun 9, 2025
30cb3d7
:ambulance: fix tests
Joachim-Lebrun Jun 9, 2025
4b1a1ba
Merge pull request #117 from onchain-id/claimissuer-factory
Joachim-Lebrun Jun 9, 2025
27ebaec
:heavy_plus_sign: add Format Resolver
Joachim-Lebrun Jun 9, 2025
5a8811b
:ambulance: fix TopicIdMapping
Joachim-Lebrun Jun 9, 2025
0155b9b
Merge branch 'develop' into bt-704-update-topic-id-mapping
Joachim-Lebrun Jun 9, 2025
c2b622a
Merge pull request #118 from onchain-id/bt-704-update-topic-id-mapping
Joachim-Lebrun Jun 9, 2025
01d842b
:sparkles: add script to flatten files
Joachim-Lebrun Jun 9, 2025
44d358d
Merge remote-tracking branch 'origin/develop' into enhancements-dev
Joachim-Lebrun Jun 9, 2025
6f13963
:construction: fix some update issues
Joachim-Lebrun Jun 9, 2025
9f23520
:white_check_mark: add nested exec tests
Joachim-Lebrun Jun 17, 2025
6cbd8ae
♻️ Use UUPSUpgradeable for ClaimIssuer
pgonday Jun 17, 2025
926b730
minimum version
Jun 3, 2025
511eafe
remove console.log
Jun 3, 2025
d4a15ca
remove keys
Jun 3, 2025
1c23019
refactor custom error
Jun 3, 2025
a2aa652
format test file
Jun 3, 2025
6aa7389
remove unused code
Jun 3, 2025
d5ed130
refactor tests
Jun 13, 2025
a2274fb
remove unused variables
Jun 13, 2025
8fccc96
update execute function check
Jun 18, 2025
7e35fa9
add test for approve pending execution flow
Jun 18, 2025
2559a7d
adapt nested logic
Jun 23, 2025
51263ba
remove redundant imports
Jun 23, 2025
1a8a89d
simplify flow
Jun 23, 2025
9959b6e
remove redundant vars
Jun 23, 2025
c4ebaec
:ambulance: fix storage management
Joachim-Lebrun Jun 25, 2025
3a7708b
:ambulance: fix function parameters
Joachim-Lebrun Jun 25, 2025
1e5f53e
:ambulance: remove useless bool return
Joachim-Lebrun Jun 25, 2025
7f27cd4
:ambulance: add input validation
Joachim-Lebrun Jun 25, 2025
1d368a0
:heavy_plus_sign: add event + fix natspec
Joachim-Lebrun Jun 25, 2025
706f32b
add event checks and case for invalid claim
Jun 25, 2025
9c7b922
add tests for all branches
Jun 25, 2025
2949062
Merge pull request #119 from onchain-id/bt-748-add-claim-other-onchai…
Joachim-Lebrun Jun 25, 2025
7aa13b6
Merge branch 'develop' into enhancements-dev
Joachim-Lebrun Jun 26, 2025
4fb5b87
Merge pull request #115 from onchain-id/enhancements-dev
Joachim-Lebrun Jun 26, 2025
450a6b6
♻️ refactored TopicIdMapping
mohamadhammoud Jul 11, 2025
7827194
💥 added getCurrentNonce, getExecutionData for identity contract
mohamadhammoud Jul 14, 2025
cc8a957
✨ added getTopics getter in TopicIdMapping
mohamadhammoud Jul 14, 2025
82b776a
✨ added getClaimsWithTopicInfo
mohamadhammoud Jul 14, 2025
6676052
🚚 rename TopicIdMapping to IdentityUtilities
mohamadhammoud Jul 15, 2025
ac40403
🚚 rename getTopics to getTopicInfos
mohamadhammoud Jul 15, 2025
334bd91
🩹 fix getExecutionData returned data
mohamadhammoud Jul 15, 2025
3e67090
Merge pull request #120 from onchain-id/feature/BT-1068-refactor-topi…
Joachim-Lebrun Jul 16, 2025
1057ac4
Merge pull request #121 from onchain-id/feature/BT-1069-add-getters-f…
Joachim-Lebrun Jul 16, 2025
12b98d3
⬆️ upgrade ethersv5 to ethersv6
mohamadhammoud Jul 16, 2025
c0e2b20
Merge pull request #122 from onchain-id/feature/BT-1072-upgrade-to-et…
Joachim-Lebrun Jul 16, 2025
170b012
♻️ added internal approve method, refactor function addClaimTo
mohamadhammoud Jul 20, 2025
0e681fb
:bookmark: v2.2.2-beta3
Joachim-Lebrun Jul 21, 2025
c1d2f74
✅ coverage 95% for IdentityUtilities
mohamadhammoud Jul 22, 2025
cccf585
✅ coverage 100% for Identity Utilities
mohamadhammoud Jul 25, 2025
525dc09
✅ coverage 99.1% for Identity.sol
mohamadhammoud Jul 25, 2025
d7c7477
Merge branch 'develop' into feature/BT-1079-test-coverage-for-identit…
mohamadhammoud Jul 25, 2025
4aef12f
✅ cover 100% ClaimIssuerFactory.sol
mohamadhammoud Jul 25, 2025
6b2a4c2
Merge branch 'feauture/BT-949-add-approve-internal-method' into featu…
mohamadhammoud Jul 25, 2025
c50ebb5
💥 added try catch to ClaimIssuer::addClaimTo
mohamadhammoud Jul 25, 2025
ee8893c
Merge branch 'feauture/BT-949-add-approve-internal-method' into featu…
mohamadhammoud Jul 28, 2025
8f122f9
Merge pull request #123 from onchain-id/feauture/BT-949-add-approve-i…
Joachim-Lebrun Jul 28, 2025
78c38e6
✅ coverage 100% for Identity contract
mohamadhammoud Jul 28, 2025
81c9a86
⚰️ removed Verifier.sol
mohamadhammoud Jul 28, 2025
0c6d666
💚 added push_check workflow
mohamadhammoud Jul 28, 2025
056ace1
Merge branch 'develop' into feature/BT-1079-test-coverage-for-identit…
mohamadhammoud Jul 28, 2025
26a9fc6
💚 fix coverage CI
mohamadhammoud Jul 28, 2025
593dfbc
💚 upgrade node version
mohamadhammoud Jul 29, 2025
ff6bea3
✨ added Multicall for identity contract
mohamadhammoud Jul 29, 2025
5af45f1
💥 inherit IERC165 in idenitity.sol
mohamadhammoud Jul 29, 2025
079c0ae
Merge pull request #124 from onchain-id/feature/BT-1079-test-coverage…
Joachim-Lebrun Jul 30, 2025
7642f7e
Merge pull request #125 from onchain-id/feature/BT-1179-identity-mult…
Joachim-Lebrun Jul 30, 2025
bacfe3a
💚 added solhint workflow
mohamadhammoud Jul 30, 2025
7410b91
💥 migrated linting configurations
mohamadhammoud Jul 30, 2025
adda46c
💚 covered line 86 for claim issuer
mohamadhammoud Jul 30, 2025
71fc48b
💚 covered line 694 in Identity contract
mohamadhammoud Jul 30, 2025
639cd9d
♻️ refactor key management methods
mohamadhammoud Jul 31, 2025
a5b2e9e
✅ cover the uncovered lines for new changes for identity
mohamadhammoud Jul 31, 2025
362f494
🚨 fix lint errors
mohamadhammoud Jul 31, 2025
aa66e71
♿️ added management keys and key types when needed
mohamadhammoud Jul 31, 2025
c889b37
💥 applied ERC7201 to Identity contract
mohamadhammoud Aug 1, 2025
b351cec
💥 applied OZ ERC7201 spec formula
mohamadhammoud Aug 4, 2025
8945235
🚨 fixed linting errors
mohamadhammoud Aug 25, 2025
4dce651
Merge pull request #126 from onchain-id/feature/BT-1108-github-lint-c…
Joachim-Lebrun Aug 25, 2025
f484b77
Merge branch 'feature/BT-1108-github-lint-coverage-workflows' into fe…
mohamadhammoud Aug 25, 2025
64b7db4
⚰️ removed __Identity_init code and used _setupInitialManagementKey
mohamadhammoud Aug 25, 2025
e390097
💥 added upgreadeable 1967 to claim issuer and applied ERC7201
mohamadhammoud Aug 27, 2025
64c0fdd
🚨 added ordering error
mohamadhammoud Sep 4, 2025
072230a
🐛 Correct isClaimValid
pgonday Sep 23, 2025
62f5685
Merge pull request #130 from onchain-id/bug-utilities
Joachim-Lebrun Oct 10, 2025
79d730b
🗑️ removed custo recover method
mohamadhammoud Oct 13, 2025
72e585b
💥 added UUPSUpgradeable to claim issuer, removed version contract
mohamadhammoud Oct 13, 2025
fb3dcea
🔖 version 3.0.0
mohamadhammoud Oct 13, 2025
6689657
💥 removed version storage in identity
mohamadhammoud Oct 13, 2025
be1f67a
Merge pull request #127 from onchain-id/feature/BT-1183-refactor-iden…
Joachim-Lebrun Oct 13, 2025
737c740
🐛 Allow only valid claims in addClaim
pgonday Oct 24, 2025
cf30379
♻️ migrated to Foundry, deleted hardhat configs
mohamadhammoud Feb 21, 2026
1d607a8
💚 refactor github actions
mohamadhammoud Feb 21, 2026
46ea70c
💥 applied enumerable set
mohamadhammoud Feb 22, 2026
48a1d88
♻️ inspired by template
mohamadhammoud Feb 23, 2026
1e8f02b
✅ coverage 100%
mohamadhammoud Feb 23, 2026
fdf938e
💡 fixed natspec
mohamadhammoud Feb 23, 2026
3d05b85
Merge branch 'feature/BT-1497-migrate-to-foundry' into feature/BT-149…
mohamadhammoud Feb 23, 2026
5fdf033
⚰️ removed unneeded tests
mohamadhammoud Feb 23, 2026
135f53d
Merge pull request #136 from onchain-id/fix/claim-valid
Joachim-Lebrun Feb 24, 2026
e94c071
:boom: make approve() finalize executions
mohamadhammoud Feb 24, 2026
778e494
🔧 Merge branch 'develop' into feature/BT-1497-migrate-to-foundry
mohamadhammoud Feb 24, 2026
1cfe7eb
🔧 fix lint
mohamadhammoud Feb 24, 2026
bf3fd5c
🚨 Merge branch 'feature/BT-1497-migrate-to-foundry' into feature/BT-1…
mohamadhammoud Feb 24, 2026
cdc7135
🗑️ updated _extractSelector method
mohamadhammoud Feb 24, 2026
78ef1c0
✅ fix coverage
mohamadhammoud Feb 24, 2026
505f8c9
🗑️ Merge branch 'feature/BT-1497-migrate-to-foundry' into feature/BT-…
mohamadhammoud Feb 24, 2026
e70f316
🗑️ deleted ts files and moved test contracts to test folder
mohamadhammoud Feb 25, 2026
93e275d
🗑️ fix lint
mohamadhammoud Feb 25, 2026
f0a3483
🗑️ Merge branch 'feature/BT-1497-migrate-to-foundry' into feature/BT-…
mohamadhammoud Feb 25, 2026
d89cf84
Merge pull request #143 from onchain-id/feature/BT-1497-migrate-to-fo…
Joachim-Lebrun Mar 5, 2026
0823e69
♻️ updated enumerable usage
mohamadhammoud Mar 5, 2026
c93f62d
Merge pull request #144 from onchain-id/feature/BT-1498-enumerable-set
Joachim-Lebrun Mar 6, 2026
f322f65
♻️ Use OZ for beacon
pgonday Mar 9, 2026
ac0c249
Merge pull request #147 from onchain-id/oz-beacon
Joachim-Lebrun Mar 9, 2026
119b73f
Feature/bt 1496 identity setup single transaction (#142)
mohamadhammoud Apr 8, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .editorconfig

This file was deleted.

47 changes: 0 additions & 47 deletions .eslintrc.js

This file was deleted.

51 changes: 51 additions & 0 deletions .github/scripts/coverage.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
#!/bin/bash

FAIL=0

echo "Generating coverage report..."
COVERAGE_OUTPUT=$(forge coverage --no-match-coverage "(test|script|dependencies|FormatResolver)" --report summary)

# Display the coverage report
echo "=== Coverage Report ==="
echo "$COVERAGE_OUTPUT"
echo "======================="

TOTAL_LINE=$(echo "$COVERAGE_OUTPUT" | grep "| Total.*|")

if [ -z "$TOTAL_LINE" ]; then
echo "❌ Could not find Total coverage line"
exit 1
fi

LINE_COV=$(echo "$TOTAL_LINE" | awk -F'|' '{print $3}' | grep -o '[0-9]*\.[0-9]*%' | sed 's/%//')
STMT_COV=$(echo "$TOTAL_LINE" | awk -F'|' '{print $4}' | grep -o '[0-9]*\.[0-9]*%' | sed 's/%//')
BRANCH_COV=$(echo "$TOTAL_LINE" | awk -F'|' '{print $5}' | grep -o '[0-9]*\.[0-9]*%' | sed 's/%//')
FUNC_COV=$(echo "$TOTAL_LINE" | awk -F'|' '{print $6}' | grep -o '[0-9]*\.[0-9]*%' | sed 's/%//')

if [ "$(echo "$LINE_COV < 100" | bc -l)" = "1" ]; then
echo "❌ Line coverage ($LINE_COV%) is below 100%"
FAIL=1
fi

if [ "$(echo "$STMT_COV < 100" | bc -l)" = "1" ]; then
echo "❌ Statement coverage ($STMT_COV%) is below 100%"
FAIL=1
fi

if [ "$(echo "$BRANCH_COV < 100" | bc -l)" = "1" ]; then
echo "❌ Branch coverage ($BRANCH_COV%) is below 100%"
FAIL=1
fi

if [ "$(echo "$FUNC_COV < 100" | bc -l)" = "1" ]; then
echo "❌ Function coverage ($FUNC_COV%) is below 100%"
FAIL=1
fi

if [ $FAIL = 1 ]; then
echo ""
echo "Coverage check failed! All metrics must be 100%"
exit 1
else
echo "✅ Coverage requirements met!"
fi
52 changes: 52 additions & 0 deletions .github/workflows/foundry-gas-diff.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: Report gas diff

on:
push:
branches:
- main
pull_request:
paths:
- contracts/**
- .github/workflows/foundry-gas-diff.yml

env:
HUSKY: 0
ALCHEMY_KEY: ${{ secrets.ALCHEMY_KEY }}

jobs:
compare_gas_reports:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: recursive

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: stable

- name: Install dependencies
run: forge soldeer install

- name: Run tests
run: forge test --gas-report > gasreport.ansi
env:
FOUNDRY_FUZZ_SEED: 0x${{ github.event.pull_request.base.sha || github.sha }}

- name: Compare gas reports
uses: Rubilmax/foundry-gas-diff@v3
with:
summaryQuantile: 0.9
sortCriteria: avg,max
sortOrders: desc,asc
ignore: test/**/*
id: gas_diff

- name: Add gas diff to sticky comment
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
uses: marocchino/sticky-pull-request-comment@v2
with:
# delete the comment in case changes no longer impact gas costs
delete: ${{ !steps.gas_diff.outputs.markdown }}
message: ${{ steps.gas_diff.outputs.markdown }}
47 changes: 47 additions & 0 deletions .github/workflows/foundry.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Foundry

on:
push:
branches:
- main
pull_request:
workflow_dispatch:

env:
HUSKY: 0
ALCHEMY_KEY: ${{ secrets.ALCHEMY_KEY }}

jobs:
check:
strategy:
fail-fast: true

name: Foundry project
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: recursive

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: stable

- name: Show Forge version
run: forge --version

- name: Install dependencies
run: forge soldeer install

- name: Run fmt
run: forge fmt --check

- name: Run build
run: forge build --sizes

- name: Run tests
run: forge test -vvv

- name: Run coverage
run: ./.github/scripts/coverage.sh
49 changes: 0 additions & 49 deletions .github/workflows/publish-prerelease.yml

This file was deleted.

49 changes: 0 additions & 49 deletions .github/workflows/publish-release.yml

This file was deleted.

56 changes: 0 additions & 56 deletions .github/workflows/push_checking.yml

This file was deleted.

Loading