New update to the Table component#38
Open
JExcellence wants to merge 8 commits intoonce-ui-system:mainfrom
Open
New update to the Table component#38JExcellence wants to merge 8 commits intoonce-ui-system:mainfrom
JExcellence wants to merge 8 commits intoonce-ui-system:mainfrom
Conversation
…el; tidy quotes
- Normalize `isOpen` prop behavior across interactive components and docs/examples
(consistent controlled/uncontrolled behavior, SSR-safe defaults).
Touched: Dialog.tsx, DialogExample.tsx, dialog.mdx,
DropdownWrapper.tsx, DropdownWrapperExample.tsx, dropdownWrapper.mdx,
ContextMenu.tsx, Select.tsx, Kbar.tsx, ComponentsCheckPage.tsx
- Input: resolve placeholder/label overlap + ID wiring
- Correct label/placeholder interaction and focus/blur states
- Ensure `htmlFor` ↔ `id` pairing; improve a11y (`aria-*`)
- Styling tweaks in Input.module.scss; updated examples
Touched: Input.module.scss, InputExamples.tsx, TextareaExamples.tsx
- Misc cleanups
- Quote consistency (`'` → `"` where needed), minor TS/prop nits
- Example + demo updates (Countdown/Count/TypeFx, Date* pickers, CTA, Button, etc.)
Touched: Accordion.tsx, Button.tsx, ChartHeader.tsx, CountdownFxExample.tsx,
CountFxExample.tsx, Cta.tsx, DateInput.tsx, DatePicker.tsx,
DatePickerExamples.tsx, DateRangeInput.tsx, emojiPickerDropdown.mdx,
EmojiPickerDropdownExample.tsx, error.tsx, Select.tsx,
ToastExample.tsx, TypeFxCustomExample.tsx
No breaking changes expected.
add ./idea to .gitignore
fix(ui): adjust Input component height for placeholder-only inputs
…tion - Add search functionality with real-time filtering across all columns - Implement dynamic actions column with customizable row-level buttons - Add pagination support with configurable page sizes and navigation - Support sortable columns with visual indicators - Add loading and empty state customization via props - Implement table variants: striped, hoverable, compact, clickable, sticky header - Add proper BEM SCSS architecture with Once UI design tokens - Fix actions column alignment and icon display - Add missing icons (edit, trash, mail, download) to icons.ts - Change "Rows per page" to "Entries per page" for clarity - Remove "Showing X rows" footer text - Improve sticky header with darker background and shadow on scroll - Optimize pagination select width for better UX - Add proper vertical centering for action buttons - Style action buttons with radius-l and increased padding - Support custom loadingState and emptyState props - Add comprehensive examples in ComponentsCheckPage
# Conflicts: # packages/core/src/components/Dialog.tsx
# Conflicts: # packages/core/src/icons.ts
|
@JExcellence is attempting to deploy a commit to the Dopler Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(Table): enhance table component with search, actions, and pagination