Code Validator and Reference Validator enhancements#46
Open
LakshmiDintakurty wants to merge 3 commits intoonc-healthit:masterfrom
Open
Code Validator and Reference Validator enhancements#46LakshmiDintakurty wants to merge 3 commits intoonc-healthit:masterfrom
LakshmiDintakurty wants to merge 3 commits intoonc-healthit:masterfrom
Conversation
…ed using dataSource instead of connection
Contributor
|
Note: Please do not close this PR. Even though we are highly out of sync, and it is years later, it is an excellent reference that a lot of work went into. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Enhancements: Below are the list of code changes made for code-validator (and reference-ccda-validator). Please review the changes and let us know if you need any additional information and we can setup a meeting to discuss.
Async thread pool for code validation
Fixed Thread safety issues in Vocab validator
VTD – Object pool pre-compiled XPaths
Switched from HSQL to H2 DB
Vocab lookup using Java HashSets/HashMaps instead of JPA queries
DB Cleanup after loading codes and valuesets to HashSets
ReferenceCCDAValidationService : Added new overloaded service methods to handle document validation
Added new functionality to support R1.1 CCDA doc Vocabulary Validation (VocabularyValidationService)
Ability to upload a compressed file for validation in addition to plain xml file to improve network latency
Perform MDHT & Vocab Validation of a document regardless whether the doc has schemaError or not, to better handle MU3 CERT Validator negative test cases
Support 100% accurate source CCDA file Line Numbers for each of the Vocabulary Validation error/warning/info results.
For supportability, added the Vocabulary Conformance Rule ID feature