Skip to content

Geolocation types refinement #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coopbri merged 12 commits into from
Dec 11, 2025
Merged

Geolocation types refinement #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ac6ac1b
build(deps): upgrade dependencies
coopbri Dec 3, 2025
dedfc16
build(deps): upgrade dependencies
coopbri Dec 7, 2025
bc38628
build(deps): upgrade Knip
coopbri Dec 11, 2025
8a2d288
build(deps): upgrade dependencies
coopbri Dec 11, 2025
6cc7bb3
test: remove `cameraSource` usage
coopbri Dec 11, 2025
af20406
refactor: migrate from namespace imports to direct imports
coopbri Dec 11, 2025
300276b
refactor(fiducial): replace `this` internals with closure vars
coopbri Dec 11, 2025
f7fdef1
refactor(geo): remove explicit type casts
coopbri Dec 11, 2025
5de0399
test: fix tests for undefined options
coopbri Dec 11, 2025
5534afa
refactor(geo): update types structure
coopbri Dec 11, 2025
891ee9e
chore(geo): remove comment
coopbri Dec 11, 2025
a5ac19d
ci: add changeset
coopbri Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/huge-pets-take.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@omnidotdev/rdk": patch
---

Improve geolocation module types
12 changes: 6 additions & 6 deletions apps/fiducial-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@
"@biomejs/biome": "^2.3.8",
"@types/react": "^19.2.7",
"@types/react-dom": "^19.2.3",
"@types/three": "^0.181.0",
"@vitejs/plugin-react": "^5.1.1",
"@types/three": "^0.182.0",
"@vitejs/plugin-react": "^5.1.2",
"typescript": "^5.9.3",
"vite": "^7.2.6",
"vite": "^7.2.7",
"vite-plugin-mkcert": "^1.17.9",
"vite-tsconfig-paths": "^5.1.4"
},
"dependencies": {
"@ar-js-org/ar.js": "^3.4.7",
"@omnidotdev/rdk": "workspace:*",
"@react-three/fiber": "^9.4.2",
"react": "^19.2.0",
"react-dom": "^19.2.0",
"three": "^0.181.2"
"react": "^19.2.1",
"react-dom": "^19.2.1",
"three": "^0.182.0"
}
}
14 changes: 7 additions & 7 deletions apps/geolocation-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@
"@biomejs/biome": "^2.3.8",
"@types/react": "^19.2.7",
"@types/react-dom": "^19.2.3",
"@types/three": "^0.181.0",
"@vitejs/plugin-react": "^5.1.1",
"@types/three": "^0.182.0",
"@vitejs/plugin-react": "^5.1.2",
"typescript": "^5.9.3",
"vite": "^7.2.6",
"vite": "^7.2.7",
"vite-plugin-mkcert": "^1.17.9",
"vite-tsconfig-paths": "^5.1.4"
},
"dependencies": {
"@omnidotdev/rdk": "workspace:*",
"@react-three/fiber": "^9.4.2",
"locar": "^0.1.6",
"react": "^19.2.0",
"react-dom": "^19.2.0",
"three": "^0.181.2"
"locar": "^0.1.7",
"react": "^19.2.1",
"react-dom": "^19.2.1",
"three": "^0.182.0"
}
}
6 changes: 3 additions & 3 deletions apps/geolocation-demo/src/components/Compass.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useFrame } from "@react-three/fiber";
import { useRef } from "react";

import type * as THREE from "three";
import type { Group } from "three";

interface CompassProps {
/**
Expand All @@ -23,8 +23,8 @@ const Compass = ({
color = "#c0392b",
scale = 1,
}: CompassProps) => {
const groupRef = useRef<THREE.Group>(null),
needleRef = useRef<THREE.Group>(null);
const groupRef = useRef<Group>(null),
needleRef = useRef<Group>(null);

// gentle floating and needle rotation animation
useFrame((state) => {
Expand Down
4 changes: 2 additions & 2 deletions apps/geolocation-demo/src/components/GPSPin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useFrame } from "@react-three/fiber";
import { useRef } from "react";

import type * as THREE from "three";
import type { Group } from "three";

interface GPSPinProps {
/**
Expand All @@ -23,7 +23,7 @@ const GPSPin = ({
color = "#ff4444",
scale = 1,
}: GPSPinProps) => {
const groupRef = useRef<THREE.Group>(null);
const groupRef = useRef<Group>(null);

// gentle floating animation
useFrame((state) => {
Expand Down
5 changes: 3 additions & 2 deletions apps/geolocation-demo/src/components/Landmark.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useFrame } from "@react-three/fiber";
import { useRef } from "react";

import type * as THREE from "three";
import type { Group } from "three";

interface LandmarkProps {
/**
Expand All @@ -26,7 +26,7 @@ const Landmark = ({
color = "#4a90e2",
scale = 1,
}: LandmarkProps) => {
const groupRef = useRef<THREE.Group>(null);
const groupRef = useRef<Group>(null);

// subtle rotation animation
useFrame((state) => {
Expand Down Expand Up @@ -86,6 +86,7 @@ const Landmark = ({
))}

{[...Array(3)].map((_, idx) => (
// biome-ignore lint/suspicious/noArrayIndexKey: fixed-length, static
<mesh key={idx + 3} position={[0.25, 0.3 + idx * 0.4, 0.31]}>
<planeGeometry args={[0.15, 0.15]} />
<meshStandardMaterial color="#87ceeb" />
Expand Down
12 changes: 6 additions & 6 deletions apps/immersive-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
"@biomejs/biome": "2.3.8",
"@types/react": "^19.2.7",
"@types/react-dom": "^19.2.3",
"@types/three": "^0.181.0",
"@vitejs/plugin-react": "^5.1.1",
"@types/three": "^0.182.0",
"@vitejs/plugin-react": "^5.1.2",
"typescript": "~5.9.3",
"vite": "^7.2.6",
"vite": "^7.2.7",
"vite-plugin-mkcert": "^1.17.9",
"vite-tsconfig-paths": "^5.1.4"
},
Expand All @@ -27,8 +27,8 @@
"@react-three/drei": "^10.7.7",
"@react-three/fiber": "^9.4.2",
"@react-three/xr": "^6.6.28",
"react": "^19.2.0",
"react-dom": "^19.2.0",
"three": "^0.181.2"
"react": "^19.2.1",
"react-dom": "^19.2.1",
"three": "^0.182.0"
}
}
8 changes: 4 additions & 4 deletions apps/immersive-demo/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Box, Center, Sphere, Text, Torus } from "@react-three/drei";
import { Canvas, useFrame } from "@react-three/fiber";
import { useRef } from "react";

import type * as THREE from "three";
import type { Mesh } from "three";

const BUTTON_STYLES = {
padding: "12px 24px",
Expand All @@ -16,7 +16,7 @@ const BUTTON_STYLES = {
};

const RotatingTorus = () => {
const meshRef = useRef<THREE.Mesh>(null);
const meshRef = useRef<Mesh>(null);

useFrame((state) => {
if (meshRef.current) {
Expand All @@ -39,7 +39,7 @@ const RotatingTorus = () => {
};

const FloatingSphere = () => {
const meshRef = useRef<THREE.Mesh>(null);
const meshRef = useRef<Mesh>(null);

useFrame((state) => {
if (meshRef.current) {
Expand All @@ -62,7 +62,7 @@ const FloatingSphere = () => {
};

const PulsatingBox = () => {
const meshRef = useRef<THREE.Mesh>(null);
const meshRef = useRef<Mesh>(null);

useFrame((state) => {
if (meshRef.current) {
Expand Down
Loading
Loading