backend for ROC & add config to this folder#2
backend for ROC & add config to this folder#2ghost wants to merge 5 commits intoonf-release3.0.5-rocfrom unknown repository
Conversation
Merge pull request #1 from pingping-lin/onf-release3.0.5
ghost
requested review from
badhrinathpa and
thakurajayL
and removed request for
badhrinathpa and
thakurajayL
| for target in $(DOCKER_TARGETS); do \ | ||
| DOCKER_BUILDKIT=$(DOCKER_BUILDKIT) docker build $(DOCKER_BUILD_ARGS) \ | ||
| --target $$target \ | ||
| --no-cache \ |
There was a problem hiding this comment.
Why we need this ?this will slow down the build process right ?
There was a problem hiding this comment.
Why we need this ?this will slow down the build process right ?
I replied this yesterday, but looks did not show up, reply again. If with cache some times the building result is not correct, for this reason, I waste a lot of time on debugging, and find it did not work just because used cache. Compare with the saved time, i would rather choose to build without cache. If you prefer with cache, I will change it back.
| @@ -0,0 +1,8 @@ | |||
| info: | |||
There was a problem hiding this comment.
is this the same config we are pulling from 5gc repository ? or this is something else?
There was a problem hiding this comment.
yes, because it uses the config in another repo. In this way, the webconsole repo will not depend on other repo.
| } | ||
| } else { | ||
| DefaultWebUIConfigPath := path_util.Free5gcPath("free5gc/config/webuicfg.yaml") | ||
| DefaultWebUIConfigPath := path_util.Free5gcPath("webconsole/config/webuicfg.yaml") |
There was a problem hiding this comment.
Let's discuss this in meeting. we are changing configpath. DId we change helm chart for the same ?
There was a problem hiding this comment.
There is yaml file, .conf file. I am not sure how it works.
1 participant
No description provided.