Override omero.db.name (fix #16)#17
Open
joshmoore wants to merge 2 commits intoome:masterfrom
Open
Conversation
omego assumes that the DBHOSE and DBNAME are set via bin/omero config. DBNAME was previously *not* set to prevent an accidental upgrade of a database. Here we set DBNAME only if the database has not been created elsewhere.
387bef5 to
219a7a8
Compare
Member
Author
|
Member
Author
|
There's a bug here in that the |
Member
|
I think the init vs upgrade logic in this PR is too complicated, and we'd be better off giving them the same behaviour. If you want to make a breaking change to omego I'm fine with that. |
Member
Author
|
@manics : you were right, this will require |
Member
Author
|
@manics, and one more? ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omego assumes that the DBHOSE and DBNAME are set via
bin/omero config. DBNAME was previously not set to
prevent an accidental upgrade of a database. Here we
set DBNAME only if the database has not been created
elsewhere.