Repository navigation
fix: keep the syncing file name visible during bulk syncs - #138
Merged
Merged
Conversation
- skip lookups and rescans for files Syncthing already reported finished; they blocked the event loop for up to minutes during a pull - run directory rescans in the background; the scan request waits for the pull and hit the 8 s response timeout - report file events before refreshing, and keep the last name for 1.5 s when a file starts and finishes within one batch - keep the Omarchy folder card alive instead of rebuilding it per update - rebuild bundled binaries and checksums
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137.
During bulk pulls the folder card's activity line stayed blank or frozen because the core's event loop blocked on HTTP calls that are redundant during a pull. Details and measurements are in #137.
Changes:
localIndexlookups and rescans for filesItemFinishedalready reported in the last 30 s; local changes are still classified and rescanned as before/rest/db/scanwaits for the pull and blocked the loop until the 8 s response timeoutRepeaterrebuild it on every status update; drop the now unusedvisibleFolderRowsCaelestia and Dux Shell get the core fixes and needed no QML change; they do not rebuild their card.
Testing
TestLastFileStaysVisibleBrieflyandTestLocalIndexSkipsFilesAlreadyReportedFinished;TestLocalIndexUsesCurrentFileInformationnow waits for the background rescango -C core test -race ./...passespackaging/bundled/build.shwith go1.23.12 reproduces the committed checksumstests/architecture.test.shandtests/native-core-architecture.test.shpassRemoving README.md) still show