Repository navigation
fix: let web ui cleanup leave themes the adapter does not own - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webui.remove-profilerefused to run when any theme other than default or theadapter's own was selected, such as Syncthing's Dark. Users hit an error for a
setting that has nothing to do with the plugin.
Only one case needs care: deleting an adapter's files while its own theme is
selected. So the rule is now:
Also in this PR:
hosts/omarchyis unchanged: it has its own removal script.Testing
TestProfileCleanupLeavesAThemeItDoesNotOwn, fails without the fixverify.sh, checksums, installation,architecture and device-sharing tests pass
tests/plugin-ui.test.sh; the only QML change is one message