Repository navigation
Conversation
Omarchy gives third-party widgets on a replacement bar such as Station a shell whose serviceFor returns null, so the panel opens with no data. The service now publishes itself in a library beside the panel, and the panel falls back to it when the direct lookup returns nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
@thenitai nice catch maybe two questions for me to understand this better
the first question is bc. then I know how much effort I have to put into testing the station bar myself (testing myself is fine, I just want to have the info) the second, bc I can build on your fix to make it work across different replacement bars if there are other popular and regularly used candidates thanks for the PR |
Author
Member
|
nice, thanks for the reply ! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
With a replacement bar such as Station selected, the Syncthing panel shows no data. Omarchy still runs the plugin's service, but the shell it gives third-party widgets on a replacement bar has no service lookup, so
bar.shell.serviceFor(moduleName)returns null.Fix
OmarchyServicepublishes itself in a newhosts/omarchy/Bridge.jsand clears itself on destruction.OmarchyPanelstill prefersserviceFor. Only when that returns null does it poll the bridge once a second, so the built-in bar's path is unchanged.This is the same pattern as crmne/omatasks#27, SirWizardLizard/omarchy-caldav-calendar#24 and nabdalla-prog/Rimuru-screentime#2.
Testing
tests/replacement-bar.test.sh, which also runs fromplugin-ui.test.sh. It covers the bridge fallback,serviceFortaking priority, and a retired service not clearing its replacement. It fails when the service stops publishing.architectureandplugin-acceptance-lintpass on this branch.folder-overviewanddropdown-searchfail on my desktop session. On unpatchedmainthey fail with the same errors; I didn't run unpatcheddev.mainbuild (not thisdevbranch), on Omarchy 4.0.6 under Station. After a shell restart the panel shows folders, devices and file totals.🤖 Generated with Claude Code