Repository navigation
Conversation
installDefaultWallpapers always wrote to ~/Wallpapers/Aether, so a user who had chosen another wallpaper folder got ~/Wallpapers recreated on every launch. It now installs into the configured folder, and skips a configured folder that is missing instead of creating it.
[Medium impact] This PR appears safe to merge. SummaryBundled wallpapers now install into the saved wallpaper folder instead of always using
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "Install default wallpapers into the conf..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
installDefaultWallpapersruns on every launch and always writes toplatform.WallpaperDir(), i.e.~/Wallpapers/Aether. It ignores thewallpaperFoldersetting thatChooseWallpaperFoldersaves andScanLocalWallpapersreads. A user who keeps their wallpapers elsewhere (for example~/Pictures/Wallpapers) and deletes~/Wallpapersgets it recreated on the next launch, and the bundled Aether wallpapers never show up in the folder they actually browse.Change
installDefaultWallpapersresolves the folder withwallpaperFolderFromConfig(readConfigJSON("settings.json")), the same lookupScanLocalWallpapersuses, and installs into<folder>/Aether.~/Wallpapers/Aetheris created as before.startupalready logs. This matchesScanLocalWallpapers, which reports a missing configured folder instead of creating it, and avoids leaving a stub directory where an unmounted drive belongs.Tests
TestInstallDefaultWallpapersUsesConfiguredFolder: wallpapers land in the configured folder and~/Wallpapersis not created.TestInstallDefaultWallpapersSkipsMissingConfiguredFolder: a missing configured folder is neither created nor replaced by~/Wallpapers.TestInstallDefaultWallpapersnow setsXDG_CONFIG_HOMEto a temp dir, so it can't pick up a realsettings.json.go test -race -tags webkit2_41 .passes, and both new tests fail without the change.🤖 Generated with Claude Code