Separating HTML and JS, config API KEY and Improved user experience in search field #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search input force click on Search button
xmon
changed the title
Google Maps API key get parameter must use 'key' name as seen in https://developers.google.com/maps/documentation/javascript/get-api-key or it won't work Use JavaScript URL from docs
Add 'key' parameter name when loading Google Maps API JavaScript
Remove deprecation message by implementing Twig_Extension_GlobalsInterface
Author
|
@ollieLtd Is this bundle maintained or abandoned? |
Member
|
@xmon hi - I don't have much time to maintain this and I haven't got round to testing your PR yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, I solve the problem with jQuery load order.
Now we can load the js wherever we want,
And when we do not have this possibility (ie, Sonata Admin) we have a new parameter 'js_inside_html' to load the whole code together, as before.
The README.md file has been modified with the new features.
Prevent send form on Enter keypress in Search input. Now, on Enter in Search input force click on Search button
Config to include Google Maps Api Key