Add debug output using a PSR3 logger#35
Open
hslatman wants to merge 5 commits intooliverlorenz:masterfrom
Open
Add debug output using a PSR3 logger#35hslatman wants to merge 5 commits intooliverlorenz:masterfrom
hslatman wants to merge 5 commits intooliverlorenz:masterfrom
Conversation
…on issue Injecting the $logger through ClientFactory would result in an error in the React\Dns\Resolver\Factory.php file. In Factory.php line 90: [ErrorException] Warning: strpos() expects parameter 1 to be string, object given I haven't bothered too much with finding out what the problem is here.
Author
|
@oliverlorenz What do you think of this? Now that I see it again, I see that the dependency is not optional, but I could make it like that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #31, echoing is not that great for providing debug output.
This PR introduces a $logger parameter to the ClientFactory that is passed through to the MqttClient. The $logger provided should conform to the PSR3 LoggerInterface. I have done a bit of manual testing with https://github.com/WyriHaximus/reactphp-psr-3-stdio and that worked. Small example:
The MqttClient currently uses a private function debug() to log the messages that were echoed at the debug level.