Skip to content

feat: remove subscribe address requirement for eth_subscribe #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
limyeechern wants to merge 2 commits into from
Closed

feat: remove subscribe address requirement for eth_subscribe #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af634d3
feat: remove subscribe address requirement for eth_subscribe
limyeechern Dec 30, 2025
28b76f0
fix: unused variable
limyeechern Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions crates/flashblocks/src/subscription.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,10 @@ where
) -> Result<(), ErrorObject<'static>> {
match kind {
FlashblockSubscriptionKind::Flashblocks => {
let Some(FlashblockParams::FlashblocksFilter(filter)) = params else {
let Some(FlashblockParams::FlashblocksFilter(_)) = params else {
return Err(invalid_params_rpc_err("invalid params for flashblocks"));
};

if (filter.sub_tx_filter.tx_info || filter.sub_tx_filter.tx_receipt)
&& filter.sub_tx_filter.subscribe_addresses.is_empty()
{
return Err(invalid_params_rpc_err(
"invalid params for flashblocks, subcribe address required when txInfo or txReceipt is enabled",
));
}

Ok(())
}
FlashblockSubscriptionKind::Standard(_) => {
Expand Down