This repository was archived by the owner on Nov 21, 2025. It is now read-only.
Conversation
Vui-Chee
reviewed
Dec 23, 2024
Vui-Chee
approved these changes
Dec 23, 2024
Vui-Chee
left a comment
Vui-Chee
left a comment
There was a problem hiding this comment.
Other than that lone comment, I think this PR lgtm 👍!
giskook
approved these changes
Dec 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a large number of batches are not commited to L1, the sequence sender will continuously request batches, eventually leading to out-of-memory (OOM) issue.
This PR can be avoided by limiting the maximum number of batches to synchronize.
Refer to 0xPolygon#249