Ericq/fix bug #145
Open
Ericq/fix bug #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added automatic sync from example.env to .env in clean.sh - This ensures the behavior matches what's documented in README.md - Users can now modify example.env and run clean.sh to update .env
xrqin
requested review from
louisliu2048 and
xzav3r
and removed request for
louisliu2048
sieniven
reviewed
Nov 6, 2025
| set -e | ||
|
|
||
| # Parse command line arguments | ||
| FORCE_ENV=false |
There was a problem hiding this comment.
We dont have to do this fix anymore. The more correct fix should be to amend the makefile itself, and then add all variable flags for skip building, local dir repo, etc, encapsulated in makefile itself (which is the entrypoint for running the managing the devnet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add flag to sync env