Update saml_application_settings_sign_on.py#373
Update saml_application_settings_sign_on.py#373mdrdannyr wants to merge 1 commit intookta:masterfrom
Conversation
When reading from OKTA API, SAML Applications that have preconfigured attribution statements are stored within 'configuredAttributeStatements'. This is currently not passed to the results var when using get_application This fix updates the model so that the value is passed
|
To provide more context and details: This is what direct API call to OKTA using postman shows: This is what the library returns from the get_application call: As can be seen the configuredAttributeStatements are missing. OKTA docs show the following regarding this key: Uncertain if the code is correct and stands up to your own guidelines. Happy to work with someone to get this merged in |
|
closes #374 |
|
Hi @bryanapellanes-okta Hope you're both doing well. Tagging you as i see you guys are quite active in the latest commits to master. Could either of you help me out here in getting this relatively small fix into a release? |
|
@mdrdannyr I apologize for the delayed response and thank you for your submission. To ensure integrity, please provide a unit test that fails prior to your proposed change and passes with your change in place. We appreciate your engagement and thanks for using Okta! |
|
We have released the new version of the Python SDK (3.1.0). This pull request seems stale; closing it. |



When reading from OKTA API, SAML Applications that have preconfigured attribution statements are stored within 'configuredAttributeStatements'.
This is currently not passed to the results var when using get_application
This fix updates the model so that the value is passed