fix(ios): handle empty NDEF tags without waiting for timeout#262
Open
samuelkchris wants to merge 1 commit intookadan:mainfrom
Open
fix(ios): handle empty NDEF tags without waiting for timeout#262samuelkchris wants to merge 1 commit intookadan:mainfrom
samuelkchris wants to merge 1 commit intookadan:mainfrom
Conversation
Author
|
Running into this error, appreciate the fix from @samuelkchris. Please merge. |
NFCError Code 403 ("NDEF tag does not contain any NDEF message") was
causing tags to be silently skipped during discovery and explicit reads.
Handle error 403 in both readNDEF call sites:
- Tag discovery (convert function): return tag with nil cachedNdefMessage
- Explicit read (ndefReadNdef): return success with nil message
samuelkchris
force-pushed
the
bugfix/IOTA-2773_fix-ios-empty-ndef-tag-handling
branch
from
1af2774 to
150b9c8
Compare
Ajinkya-GobetterX
left a comment
Ajinkya-GobetterX
left a comment
There was a problem hiding this comment.
Tiny change but a required one, I am also using similar patched version for my app.
dlopez-penbase
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
readNDEFcall sites inios/Classes/NfcManagerPlugin.swift:convertfunction): return the tag with nilcachedNdefMessageinstead of skipping itndefReadNdef): return.success(nil)instead of.failure(error)Test plan
onDiscoveredcallback immediately with nil NDEF messageNdef.read()on an empty tag — should return nil instead of throwingFixes #259