Skip to content

fix(sidebar): MarketSidebar 빈 목록 상태 표시 (#74)#75

Merged
ohhalim merged 1 commit into
developfrom
fix/74/marketsidebar-empty-state
Jul 1, 2026
Merged

fix(sidebar): MarketSidebar 빈 목록 상태 표시 (#74)#75
ohhalim merged 1 commit into
developfrom
fix/74/marketsidebar-empty-state

Conversation

@ohhalim

@ohhalim ohhalim commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • 급상승/급하락 데이터가 없을 때 빈 화면 대신 "변동 데이터 없음" 메시지 표시
  • MoverList 컴포넌트에 items.length === 0 분기 추가

배경

백엔드 0.0% 필터 적용 후 빈 배열이 내려오는 경우에 대한 방어 처리

Test plan

  • 급상승/급하락 데이터 없을 때 "변동 데이터 없음" 표시 확인
  • 데이터 있을 때 정상 목록 렌더링 확인

Closes #74

Summary by CodeRabbit

  • Bug Fixes
    • Improved the market sidebar list view so it now shows a clear “변동 데이터 없음” message when there are no items, instead of displaying an empty list.

급상승/급하락 데이터 없을 때 "변동 데이터 없음" 메시지 표시
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 58dca6af-3c60-425b-8033-e84943d13a93

📥 Commits

Reviewing files that changed from the base of the PR and between 3ab987e and bed0acd.

📒 Files selected for processing (1)
  • src/components/layout/MarketSidebar.tsx

📝 Walkthrough

Walkthrough

The MoverList component in MarketSidebar.tsx now checks for an empty items array and renders a placeholder message ("변동 데이터 없음") instead of an empty list when there is no mover data to display.

Changes

Empty State Fix

Layer / File(s) Summary
Empty items placeholder
src/components/layout/MarketSidebar.tsx
MoverList adds an early-return branch when items.length === 0, rendering a gray placeholder message instead of an empty list.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related Issues

  • #74: fix(sidebar): MarketSidebar 급상승/급하락 빈 목록 상태 표시 누락

Suggested labels: bug, frontend

Suggested reviewers: ohhalim


🐰 A rabbit hopped by the sidebar's edge,
Found an empty list on a data ledge,
"No changes today," it hummed with cheer,
A tiny message so the void feels less severe.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목이 MarketSidebar의 빈 목록 상태 표시 수정이라는 핵심 변경을 간결하게 잘 요약합니다.
Linked Issues check ✅ Passed 빈 배열일 때 "변동 데이터 없음"을 표시하는 분기가 추가되어 #74의 요구사항을 충족합니다.
Out of Scope Changes check ✅ Passed 변경은 빈 목록 처리에만 국한되어 있어 링크된 이슈 범위를 벗어난 수정이 보이지 않습니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/74/marketsidebar-empty-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ohhalim ohhalim merged commit 4da9c8d into develop Jul 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(sidebar): MarketSidebar 급상승/급하락 빈 목록 상태 표시 누락

1 participant