prov/efa: Improve error message for ibv_create_ah failure#12136
Merged
jiaxiyan merged 1 commit intoofiwg:mainfrom Apr 16, 2026
Merged
prov/efa: Improve error message for ibv_create_ah failure#12136jiaxiyan merged 1 commit intoofiwg:mainfrom
jiaxiyan merged 1 commit intoofiwg:mainfrom
Conversation
Contributor
|
Can u confirm we have such error path tested in unit-test ? I remember I added it but worth checking.. |
shijin-aws
previously approved these changes
Apr 13, 2026
Contributor
Author
Yes we have |
a-szegel
reviewed
Apr 14, 2026
For create AH command, EINVAL currently can be returned due to non existing PD or GID, or unallowed cross AZ if the GID is in another AZ. List all the reasons before rdma core returns more specific error codes. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com>
Contributor
Author
|
bot:aws:retest |
shijin-aws
approved these changes
Apr 16, 2026
a-szegel
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For create AH command, EINVAL currently can be returned due to non existing PD or GID, or unallowed cross AZ if the GID is in another AZ. List all the reasons before rdma core returns more specific error codes.